Fix detection of immutability in case class with private field #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/flink-1-api/src/main/scala-2/org/apache/flinkx/api/LowPrioImplicits.scala
Outdated
Show resolved
Hide resolved
|
Great work! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @novakov-alexey,
As I said in this comment #248 (comment) I found a bug in the detection of the immutability of a case class with private field.
Under some circonstances (I'm not 100% sure) for exemple when a case class with private field is declared after an object, the field name in the java class takes the name
className$$fieldNameinstead of the field name only.The fix complexifies the field lookup to also handle this case.