Reflect default values for case class constructors #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o case-class-schema-evolution # Conflicts: # src/main/scala-2/org/apache/flinkx/api/serializer/ConstructorCompat.scala # src/test/scala/org/apache/flinkx/api/SchemaEvolutionTest.scala
novakov-alexey
commented
Mar 9, 2024
src/main/scala-2/org/apache/flinkx/api/serializer/ConstructorCompat.scala
Show resolved
Hide resolved
novakov-alexey
commented
Mar 9, 2024
src/main/scala/org/apache/flinkx/api/serializer/CaseClassSerializer.scala
Outdated
Show resolved
Hide resolved
novakov-alexey
commented
Apr 3, 2024
src/main/scala/org/apache/flinkx/api/serializer/CaseClassSerializer.scala
Show resolved
Hide resolved
|
Hi, I have double checked, fix looks good. Cheers. |
novakov-alexey
force-pushed
the
case-class-schema-evolution
branch
from
14e0b9d to
72c638a
Compare
novakov-alexey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive/reflect default values for case classes, when an object instance from a checkpoint/savepoint does not have enough constructor args.
This solves case class evolution problem.