Add YTPlayerView-iframe-player.html in the asset bundle #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project, we replaced the official pod (not maintained anymore) by this pod to use youtube on iOS. But we could not make it work. After investigating, we found out that there are still code path in the library that requires having the file YTPlayerView-iframe-player.html in the Assets.bundle.
In our usage, we needed to pass custom params when loading the Youtube video. Our code was like this:
This did not work even when we tried to set the
htmlUrl
param to the one in the Readme.After investigating, we found that we needed the
YTPlayerView-iframe-player.html
for loading video that way to work.The code path involved is precisely at line
ios-inline-youtube-view/InlineYoutubeView/Classes/InlineYoutubeView.m
Line 990 in a45edd7