chore: make constraints act like variants on add/update/delete #3888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
dosubot
bot
added
the
size:XXL
* chore: dont need to pass flag to variants Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> * chore: dont need to drill variants all the way down Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> * chore: wire up rollouts Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> --------- Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes constraints act like variants/rules//etc in the new ui where it requires hitting 'update' on the root object (ie segment) to actually save the changes.
soon I'll add a check for unsaved changes to warn the user before navigating away from the page