refactor: replace _.debounce() with native equivalent
#325
Conversation
| return | ||
| } | ||
|
|
||
| // If we're not in cool down, call immediately and start cool-down |
There was a problem hiding this comment.
I don't think this is the right behavior we expect from debounce.
The point is that when you are typing we want to wait DELAY ms after the last keystroke.
We need to wait for the user to stop typing and then act.
We should NOT act on the first keystroke.
There was a problem hiding this comment.
I think the correct behavior is to clear any existing timer and then schedule a new one.
There was a problem hiding this comment.
Wouldn't that completely kill auto completions?
There was a problem hiding this comment.
Isnt this the way it works now?
There was a problem hiding this comment.
No, right now there is zero cooldown for typing.
There was a problem hiding this comment.
To be clear, I understand that this implementation isn't equivalent to the _.debounce(). This is more of a rate limit.
I'm just questioning whether the old one would have worked if we were to enable it with the auto completions added.
There was a problem hiding this comment.
So we have compileOnChangeDelay, but you are saying this value is always zero?
There was a problem hiding this comment.
On the change event we are passing in a skipDelay flag that circumvents the debouncing.
There was a problem hiding this comment.
I have talked with Matt about this. We will sleep on a bit, but we are thinking of just removing all this functionality.
No decision yet though.
No description provided.