Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holdem Game: All In functionality implemented + several bug fixes #37

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Holdem Game: All In functionality implemented + several bug fixes #37

wants to merge 6 commits into from

Conversation

roessig
Copy link

@roessig roessig commented Apr 25, 2020

I implemented the logic for one or more players going all in for the Holdem Game.

Furthermore I fixed several bugs:

  • if all players except one fold, cards are not shown to the players
  • dealer seat, i.e. small and big blind are rotating
  • bet amounts are shown for all players

The implementation is surely not flawless, but it should usually be fine for playing, especially also with all-in.

emolinaab
emolinaab reviewed Apr 25, 2020
View reviewed changes
lib/holdem_game.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emolinaab emolinaab emolinaab left review comments

@Mustafadagkiranlar Mustafadagkiranlar Mustafadagkiranlar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roessig @emolinaab @Mustafadagkiranlar