Implemented i8255 and unit tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the i8255 Zig implementation isn't all that helpful when there's no system using it though ;) (in the C project, the Atom and CPC make use of it, but both are not trivial to move over, since more chip emulators are missing) |
|
PS: is the only change the bitmask thingie and fixed tests? In that case I'll probably just "backport" them to chips. |
|
Thanks! |
Yes, pretty straightforward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ported the i8255 emulation over from
chipsincluding the respective unit tests fromchips-test. Since I found some issues (floooh/chips#108) in the original implementation of the i8255 I fixed them here.