-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typo #53
docs: fix typo #53
Conversation
✅ Deploy Preview for astro-integration-kit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against it, I just feel like it's a matter of personal preferences. I'm used to camelCase but why not PascalCase! Do you have a link to the zod docs where it's recommended or to several astro core/integrations using PascalCase? I'm just trying to see what's most used
oh, sorry. here is current one const OptionsSchema = z.object({
foo: z.union([z.array(z.string()), z.literal(undefined)]).optional()
})
type Options = {
/** An insightful comment */
foo?: z.infer<typeof OptionsSchema>["foo"]
}
export default defineIntegration({
setup({ options: inputOptions }) {
const options = optionsSchema.parse(inputOptions);
return {}
}
}) |
Sorry!! I actually completely misread your PR, was on phone 😅. Looking at https://github.com/withastro/starlight/blob/main/packages/starlight/utils/user-config.ts, I think we should use |
I apologize for my lack of explanation! I changed it to PascalCase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for contributing 🚀
I feel these were typos and have corrected them.