-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The New Query Api (aka [1]007 with the license to kill redundant frontend boilerplate) #1007
Comments
Feel free to comment @SunVal, @LukasPietzschmann, @Ellpeck, @allaboutmeme. |
I only have one question: did you intentionally wait until the issue could be #[1]007? |
No, as you may see from the title change this was just a nice coincidence :D |
Once #1021 is finished, I think it location based restrictions could become useful. For instance, consider the following example where only nodes originating from the [
{
"type": "call-context",
"callName": "^except_.*$",
"kind": "check",
"subkind": "except",
"location": [ "path/to/test_file.R" ]
}
] What do you think about that (as this could theoretically also be implemented client side)? |
Thank you for the proposal, i think this should be part of the query api, but probably be outsourced into another issue, can you please create one? |
To speedup the release of 2.1.0, we no longer schedule the inclusion of all of these messages with 2.1.0 but will do so with later releases based on the demand. |
Sure, it's now tracked in (or with?) #1030 |
Alongside #980 i am creating a new query API which should be used to consume the following features:
This should be part of 2.1 which will start to deprecate the other messages. Comments are open until #980 is stable and in main, for now, you may refer to https://github.com/flowr-analysis/flowr/blob/980-context-sensitive-call-pattern-queries/wiki/Query%20API.md for the evolving documentation of the Query API.
As a benefit this would provide server/cli/... integration for new queries with just one definition, drastically reducing the boiler plate. Additionally, this allows the (re-) use of virtual queries like the compound query to group and pre-determine arguments!
The text was updated successfully, but these errors were encountered: