#JBPMP-575 Menu item "Process instances" doesn't change color when th… #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e process instances screen is showed Removed redundant urlQueryParameters which interfered with menu
| description="msg://io.openbpm.control/menu_config.bpm_ProcessInstance.list.description" | ||
| title="msg://io.openbpm.control/menu_config.bpm_ProcessInstance.list.title" icon="TASKS"> | ||
| <urlQueryParameters> | ||
| <parameter name="mode" value="active"/> |
Contributor
There was a problem hiding this comment.
This code is needed to add a tab parameter to the URL. If you remove the parameter, the URL will be empty. The highlighting error is caused by Vaadin. You can replace the parameters with URL Aliases and create three aliases for each tab.
https://vaadin.com/docs/latest/flow/routing/route#creating-route-aliases
Contributor
Author
There was a problem hiding this comment.
Decided to go with a different approach
Added new HighlightCondition for Process instances menu item, to highlight the menu item even with added url parameters
…e process instances screen is showed Added new HighlightCondition for Process instances menu item, to highlight the menu item even with added url parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e process instances screen is showed
Removed redundant urlQueryParameters which interfered with menu