Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp precision is missing fractions of a second #12

Open
EdwinEngelen opened this issue Mar 24, 2020 · 0 comments · Fixed by Floppe/NLog.Targets.Fluentd#1 · May be fixed by #13
Open

Timestamp precision is missing fractions of a second #12

EdwinEngelen opened this issue Mar 24, 2020 · 0 comments · Fixed by Floppe/NLog.Targets.Fluentd#1 · May be fixed by #13

Comments

@EdwinEngelen
Copy link

The timestamp has a precision of a whole second. That is not enough for logging.

The timestamp precision has to be increased to include fractions of a seconds. At least milliseconds.
EdwinEngelen pushed a commit to EdwinEngelen/NLog.Targets.Fluentd that referenced this issue Mar 24, 2020
@EdwinEngelenCGM
Use timestamp with subsecond precision
f1bcc52 
Previously the timestamp did have a a precision of one second. The fraction got lost.
The timestamp is a double now and contains the fractions of a second.

Fixes fluent#12
@EdwinEngelen EdwinEngelen linked a pull request Mar 24, 2020 that will close this issue
Open
EdwinEngelen added a commit to EdwinEngelen/NLog.Targets.Fluentd that referenced this issue Mar 24, 2020
@EdwinEngelen
Use timestamp with subsecond precision
4d19ccb 
Previously the timestamp did have a a precision of one second. The fraction got lost.
The timestamp is a double now and contains the fractions of a second.

Fixes fluent#12

Signed-off-by: Edwin Engelen <edwin@engelen.name>
EdwinEngelen added a commit to EdwinEngelen/NLog.Targets.Fluentd that referenced this issue Mar 26, 2020
@EdwinEngelen
Use timestamp with subsecond precision
1bf1dfd 
Previously the timestamp did have a a precision of one second. The fraction got lost.
The timestamp is a double now and contains the fractions of a second.

Fixes fluent#12

Signed-off-by: Edwin Engelen <edwin@engelen.name>
EdwinEngelen added a commit to EdwinEngelen/NLog.Targets.Fluentd that referenced this issue Mar 26, 2020
@EdwinEngelen
Send fractions of a second to Fluentd
69eddfa 
Previously the timestamp did have a a precision of one second. The fraction got lost.

The timestamp is now of the EventTime time according to specification:
https://github.com/fluent/fluentd/wiki/Forward-Protocol-Specification-v1#eventtime-ext-format

EventTime has nanosecond precision, but .NET only supports 100 nanoseconds (ticks).

Fixes fluent#12

Signed-off-by: Edwin Engelen <edwin@engelen.name>
@Floppe Floppe mentioned this issue Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@EdwinEngelen