Send fractions of a second to Fluentd #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwinEngelen
force-pushed
the
master
branch
2 times, most recently
from
4d19ccb to
1bf1dfd
Compare
|
@moriyoshi or someone else, can you please review this? |
Previously the timestamp did have a a precision of one second. The fraction got lost. The timestamp is now of the EventTime time according to specification: https://github.com/fluent/fluentd/wiki/Forward-Protocol-Specification-v1#eventtime-ext-format EventTime has nanosecond precision, but .NET only supports 100 nanoseconds (ticks). Fixes fluent#12 Signed-off-by: Edwin Engelen <edwin@engelen.name>
EdwinEngelen
changed the title
snakefoot
reviewed
Jun 19, 2021
|
|
||
| that.PackExtendedTypeValue( | ||
| 0x0, | ||
| new[] |
There was a problem hiding this comment.
Could be nice if it worked without additional byte[]-array allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the timestamp did have a a precision of one second. The fraction got lost.
The timestamp is a double now and contains the fractions of a second.
Fixes #12