Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Layout support for options Host and Tag. Bumped to NLog 4.5 #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 17, 2018

NLog Layout makes it possible to load options from config-files. Like app.config-file or appsettings.json-file.

Stop using BETA-version of NLog.

@snakefoot
Copy link
Contributor Author

@moriyoshi Have updated dependencies to the official NLog 4.5 release for NetStandard support.

@snakefoot
Copy link
Contributor Author

@moriyoshi Would love to have this merged, and have a nuget-package published

@moriyoshi
Copy link
Member

moriyoshi commented Jun 19, 2021

Hey, the title doesn't seem to describe the change. What was the intention for it?

@snakefoot snakefoot force-pushed the Vs2017 branch 3 times, most recently from 40366be to 4c5a1c9 Compare June 19, 2021 18:13
@snakefoot snakefoot changed the title Added InternalLogger for connection attempt Added InternalLogger for connection attempt. Bumped MsgPack.Cli to ver 1.0.1 Jun 19, 2021
@snakefoot
Copy link
Contributor Author

@moriyoshi Yes you are right. The changes was made to help investigation of this issue: #9 (comment)

Have now updated the title of the pull-request to correctly reflect its changes.

@snakefoot snakefoot force-pushed the Vs2017 branch 3 times, most recently from ee5092a to 79183b3 Compare June 19, 2021 18:28
@snakefoot snakefoot changed the title Added InternalLogger for connection attempt. Bumped MsgPack.Cli to ver 1.0.1 Added InternalLogger for connection attempt. Bumped to NLog 4.5 Jun 19, 2021
Signed-off-by: Rolf Kristensen <sweaty1@hotmail.com>
@snakefoot
Copy link
Contributor Author

@moriyoshi Polite poke for having this merged and nuget-package released.

Signed-off-by: Rolf Kristensen <sweaty1@hotmail.com>
@snakefoot snakefoot changed the title Added InternalLogger for connection attempt. Bumped to NLog 4.5 Added Layout support for options Host and Tag. Bumped to NLog 4.5 Aug 24, 2024
@snakefoot snakefoot force-pushed the Vs2017 branch 2 times, most recently from ca0f0b7 to 81f3209 Compare August 26, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants