Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code scaning alerts —— Incomplete regular expression for hostnames #4052

Merged
merged 2 commits into from
May 11, 2024

Conversation

xliuqq
Copy link
Collaborator

@xliuqq xliuqq commented May 7, 2024

Ⅰ. Describe what this PR does

fix code scaning https://github.com/fluid-cloudnative/fluid/security/code-scanning/945

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

xliuqq added 2 commits May 7, 2024 17:04
Signed-off-by: xliuqq <xlzq1992@gmail.com>
Signed-off-by: xliuqq <xlzq1992@gmail.com>
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.33%. Comparing base (6d0ba26) to head (b81ac42).
Report is 53 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4052   +/-   ##
=======================================
  Coverage   64.33%   64.33%           
=======================================
  Files         477      477           
  Lines       28444    28444           
=======================================
  Hits        18300    18300           
  Misses       7968     7968           
  Partials     2176     2176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented May 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit bb2d18b into fluid-cloudnative:master May 11, 2024
10 checks passed
@xliuqq xliuqq deleted the regex_check_fix branch May 17, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants