Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:support dynamic mount of subpath format JuiceFS mount-points #4241

Conversation

Syspretor
Copy link
Collaborator

Ⅰ. Describe what this PR does

Previously, dynamic-mount is supported in Version 1.0.9, users can configure the juicefs mount-point in dataset dynamically, however only the root dir can be configured. This pull request optimizes the parameter parsing logic in the juicefs mount script to support the subpath configuration of juicefs mount-points.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No tests was added.

Ⅳ. Describe how to verify it

Specify the following mount point configuration in dynamic-mount dataset, the subpath of juicefs volume can be dynamic mounted.

  - mountPoint: juicefs://$volume-name/$volume-subpath-1/.../
    name: juicefs-volume
    path: /subpath

@Syspretor Syspretor changed the title Feat:support subpath in juicefs volume dynamic-mount Feat:support dynamic mount of subpath format JuiceFS mount-points Jul 30, 2024
Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com>
@Syspretor Syspretor force-pushed the feature/support-subpath-in-juicefs-dynamic-mount branch from 7b1fb8e to cb1b481 Compare July 30, 2024 12:42
Copy link

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 81fafee into fluid-cloudnative:master Jul 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants