Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support to set single quota for multipath in tireStore.level in Jindoruntime #4476

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Syspretor
Copy link
Collaborator

@Syspretor Syspretor commented Jan 17, 2025

By design, users could set multiple cache paths when configuring tiredStore for the runtime, and there were two ways to set quotas for multiple cache paths.

The first method was to set corresponding quotas for each of the cache paths via level.quotaList.

  tieredstore:
    levels:
    - mediumtype: MEM
      volumeType: emptyDir
      path: /dev/shm/cache-subpath-1,/dev/shm/cache-subpath-2,/dev/shm/cache-subpath-3
      quotaList: 1Gi,1Gi,1Gi
      high: "0.99"
      low: "0.99"

The second method was to set a total quota for all cache paths via level.quota, where each path would receive a quota equal to the total quota divided by the number of cache paths, which is equivalent to the following configuration.

  tieredstore:
    levels:
    - mediumtype: MEM
      volumeType: emptyDir
      path: /dev/shm/cache-subpath-1,/dev/shm/cache-subpath-2,/dev/shm/cache-subpath-3
      quota: 3Gi
      high: "0.99"
      low: "0.99"

The final effective quota configuration of the two configuration examples above is equivalent.

However, currently not all runtimes support the second method; only the alluxio runtime does.

Therefore, in this PR, support for this type of quota configuration is added for the jindoruntime, and a common function to process the tiredStore is provided for three jindoruntime.Engines(jindo,jindofsx,jindocache).

Copy link

fluid-e2e-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

fluid-e2e-bot bot commented Jan 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Syspretor Syspretor force-pushed the fix/unify-implement-of-quota-in-jindoruntimes branch 3 times, most recently from cfd43a7 to c57c209 Compare January 17, 2025 08:51
@Syspretor Syspretor changed the title Support to set single quota for multipath in tireStore.level in Jindoruntime Feature: Support to set single quota for multipath in tireStore.level in Jindoruntime Jan 17, 2025
@Syspretor Syspretor force-pushed the fix/unify-implement-of-quota-in-jindoruntimes branch from c57c209 to f805f9f Compare January 17, 2025 09:17
Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com>
@Syspretor Syspretor force-pushed the fix/unify-implement-of-quota-in-jindoruntimes branch from f805f9f to 7ff9009 Compare January 17, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant