Skip to content

test(controllers): migrate runtime controller tests to Ginkgo #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hxrshxz wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

test(controllers): migrate runtime controller tests to Ginkgo #5680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08f12af
test(controllers): migrate runtime controller tests
hxrshxz Mar 6, 2026
f1be066
address review
hxrshxz Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/controllers/runtime_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,11 @@ func (r *RuntimeReconciler) AddOwnerAndRequeue(ctx cruntime.ReconcileRequestCont

// GetRuntimeObjectMeta gets runtime object meta
func (r *RuntimeReconciler) GetRuntimeObjectMeta(ctx cruntime.ReconcileRequestContext) (objectMeta metav1.Object, err error) {
if ctx.Runtime == nil || reflect.ValueOf(ctx.Runtime).IsNil() {
err = fmt.Errorf("runtime is nil")
return
}

objectMetaAccessor, isOM := ctx.Runtime.(metav1.ObjectMetaAccessor)
if !isOM {
// return utils.RequeueIfError(fmt.Errorf("object is not ObjectMetaAccessor"))
Expand Down
Loading
Loading