Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-162: Initial implementation of overlay-based 'focus fix'. #164

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

duhrer
Copy link
Contributor

@duhrer duhrer commented Feb 21, 2024

I had been intermittently seeing cases where focus styles were not displayed, this pull attempts to provide a workaround for the underlying issues.

See #162 and #161 for more details on the research and the browser behaviour that required the workaround.

@duhrer
Copy link
Contributor Author

duhrer commented Feb 21, 2024

As mentioned in the issue, the easiest way to see the underlying problem is to launch a search with the action launcher. Bumper navigating through the results does not display anything for multiple "bumps", and then finally only displays the destination URL for focused links.

With the new setting on, it's much clearer that menu elements, etc. are focused during this "invisible" period. There are two ways to enable the new setting:

  1. Open the settings panel, it's the last entry under "General Preferences".
  2. This is the first and only setting with a dedicated action to "toggle" it, so you can also open the action launcher and click "Toggle optional focus indicator".

@duhrer
Copy link
Contributor Author

duhrer commented Feb 21, 2024

In working on this, I also figured out that although the input mapper listens for local storage changes, the settings panel didn't. I fixed this, so if you change the preference through the action launcher or through the settings panel, it gets updated in any other open windows we control.

@duhrer duhrer merged commit 60ba79f into fluid-lab:main Feb 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant