GH-166: Cleaned up styles and UI grades for settings panels. #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #166 for details.
In summary, the UI grades in the settings panel were not cleanly divided, the low-level UI elements like toggles and such were also managing the labels and descriptions. I pared down the simple grades to just handle their own UI and made cleanly expressed wrapper grades for the sites that use them.
I also noticed that a lot of very similar elements were using overly specific selectors, there should have been one class for binding labels, but there were four or five. I cleaned this up and also improved the naming in general.
At the end I went through with the coverage tool in the Chrome dev tools and pared down unused styles following the refactor.
As a side effect, while I was working on this I found a bug lingering from some of the focus refactoring, where removing a binding would throw an error when attempting to focus. I fixed this.