Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-166: Cleaned up styles and UI grades for settings panels. #167

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

duhrer
Copy link
Contributor

@duhrer duhrer commented Feb 24, 2024

See #166 for details.

In summary, the UI grades in the settings panel were not cleanly divided, the low-level UI elements like toggles and such were also managing the labels and descriptions. I pared down the simple grades to just handle their own UI and made cleanly expressed wrapper grades for the sites that use them.

I also noticed that a lot of very similar elements were using overly specific selectors, there should have been one class for binding labels, but there were four or five. I cleaned this up and also improved the naming in general.

At the end I went through with the coverage tool in the Chrome dev tools and pared down unused styles following the refactor.

As a side effect, while I was working on this I found a bug lingering from some of the focus refactoring, where removing a binding would throw an error when attempting to focus. I fixed this.

@duhrer
Copy link
Contributor Author

duhrer commented Feb 24, 2024

This also fixes the misalignment of the focus styles with the binding options icons.

@duhrer duhrer merged commit b749204 into fluid-lab:main Feb 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant