use egl platform display #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2026
lhoward
reviewed
Feb 3, 2026
src/flutter/shell/platform/linux_embedded/surface/environment_egl.h
Outdated
Show resolved
Hide resolved
lhoward
reviewed
Feb 3, 2026
src/flutter/shell/platform/linux_embedded/surface/environment_egl.h
Outdated
Show resolved
Hide resolved
lhoward
reviewed
Feb 3, 2026
src/flutter/shell/platform/linux_embedded/surface/environment_egl.h
Outdated
Show resolved
Hide resolved
martinetd
commented
Feb 3, 2026
src/flutter/shell/platform/linux_embedded/surface/environment_egl.h
Outdated
Show resolved
Hide resolved
wang-bin
force-pushed
the
eglplatform
branch
2 times, most recently
from
6784ca7 to
3c508f1
Compare
required if mutiple platforms are available, otherwise egl may call into x11 and crash even if gbm is desired. tested on rk3588
|
code is formatted by clang-format |
Author
|
Thank you, this looks good to me! (and tested on wayland on my PC) @lhoward - please do the honors once you've had a look |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required if mutiple platforms are available, otherwise egl may call into x11 and crash even if gbm is desired. tested on rk3588