Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] disable all Adrenos older than 630 #57069

Merged
auto-submit merged 1 commit into from
Dec 9, 2024
Merged

[Impeller] disable all Adrenos older than 630 #57069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions impeller/renderer/backend/vulkan/driver_info_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,22 +336,18 @@ bool DriverInfoVK::IsEmulator() const {

bool DriverInfoVK::IsKnownBadDriver() const {
if (adreno_gpu_.has_value()) {
auto adreno = adreno_gpu_.value();
switch (adreno) {
// See:
// https://github.com/flutter/flutter/issues/154103
//
// Reports "VK_INCOMPLETE" when compiling certain entity shader with
// vkCreateGraphicsPipelines, which is not a valid return status.
// See https://github.com/flutter/flutter/issues/155185 .
case AdrenoGPU::kAdreno630:
// See:
// https://github.com/flutter/flutter/issues/155185
// Unknown crashes but device is not easily acquirable.
case AdrenoGPU::kAdreno506:
return true;
default:
return false;
AdrenoGPU adreno = adreno_gpu_.value();
// See:
Copy link
Member

@zanderso zanderso Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment block also link to flutter/flutter#159834 ?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same error basically, no additional info.

// https://github.com/flutter/flutter/issues/154103
//
// Reports "VK_INCOMPLETE" when compiling certain entity shader with
// vkCreateGraphicsPipelines, which is not a valid return status.
// See https://github.com/flutter/flutter/issues/155185 .
//
// https://github.com/flutter/flutter/issues/155185
// Unknown crashes but device is not easily acquirable.
if (adreno <= AdrenoGPU::kAdreno630) {
return true;
}
}
// Disable Maleoon series GPUs, see:
Expand Down
20 changes: 12 additions & 8 deletions impeller/renderer/backend/vulkan/driver_info_vk_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,18 @@ TEST(DriverInfoVKTest, DriverParsingAdreno) {

TEST(DriverInfoVKTest, DisabledDevices) {
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 630"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 620"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 610"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 530"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 512"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 509"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 508"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 506"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 505"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 504"));

EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 640"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 650"));
}

TEST(DriverInfoVKTest, EnabledDevicesMali) {
Expand All @@ -122,14 +134,6 @@ TEST(DriverInfoVKTest, EnabledDevicesAdreno) {
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 720"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 710"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 702"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 530"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 512"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 509"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 508"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 505"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 504"));

EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 506"));
}

} // namespace impeller::testing