Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

In order to, at some future date, support building Swift in the engine, we'll need an updated version of gn.

Note that all versions of gn after
f792b9756418af8ab8a91a4c15b582431cb86ff9 up to and including this version are affected by a crasher when building Swift source_set targets. The workaround to support Swift is to opt back in to stamp files until the issue is fixed.

Either way, prior to this patch, we were using a version of gn from 2021, so we should probably update to a more recent version of gn regardless.

Issue: flutter/flutter#144791

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

In order to, at some future date, support building Swift in the engine,
we'll need an updated version of `gn`.

Note that all versions of `gn` after
f792b9756418af8ab8a91a4c15b582431cb86ff9 up to and including this
version are affected by a crasher when building Swift `source_set`
targets. The workaround to support Swift is to opt back in to stamp
files until the issue is fixed.

* Bug: https://crbug.com/gn/380799198
* Discussion: http://shortn/_KbylT3nDsZ

Either way, prior to this patch, we were using a version of gn from
2021, so we should probably update to a more recent version of `gn`
regardless.

Issue: flutter/flutter#144791
@zanderso
Copy link
Member

New gn seems to have different ideas about formatting, but that's no biggie. More mysterious is the clangd failure. That might be related to the build that timed out: If the new gn changed the clang command line, that could both confuse clangd and invalidate the RBE cache.

@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

@zanderso
Copy link
Member

zanderso commented Jan 6, 2025

@cbracken I'm going to close this and assume that you'll recreate it in flutter/flutter when needed.

@zanderso zanderso closed this Jan 6, 2025
@cbracken
Copy link
Member Author

cbracken commented Jan 7, 2025

Thanks!

@cbracken cbracken deleted the update-gn branch January 7, 2025 03:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants