Delete stale package_config.json in gclient sync hook #57195
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
goderbauer
force-pushed
the
deleteCOnfigFiles
branch
from
a64ccaf to
6e6e025
Compare
| ) | ||
|
|
||
| # Delete all package_config.json files. These may be stale. | ||
| # Required ones will be regenerated fresh below. |
goderbauer
added
the
autosubmit
flutter/engine@c4e3cc2...4e4a430 2024-12-14 goderbauer@google.com Fix include path in fuchsia's analysis_options.yaml files (flutter/engine#57203) 2024-12-13 goderbauer@google.com Delete stale package_config.json in gclient sync hook (flutter/engine#57195) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
reason for revert: suspected culprit in autoroller failing to create PRs. |
jonahwilliams
added
the
revert
|
Time to revert pull request flutter/engine/57195 has elapsed. |
auto-submit
bot
removed
the
revert
link to failure log? |
This reverts commit 2f66432.
#57195 was reverted because it tried to delete non-existing files. This adds a check to only attempt to delete the file if it exists.
…#57195) On the bots there were old and stale `package_config.json` files hanging around that confuse the `dart format` command. This PR adds a step to the `pub_get_offline.py` glcient sync hook to delete all of these files that are not under version control.
…er/engine#57218) flutter/engine#57195 was reverted because it tried to delete non-existing files. This adds a check to only attempt to delete the file if it exists.
4 participants
On the bots there were old and stale
package_config.jsonfiles hanging around that confuse thedart formatcommand. This PR adds a step to thepub_get_offline.pyglcient sync hook to delete all of these files that are not under version control.