This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate FlBinaryMessenger using embedder API instead of mock engine. #57214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove most of the remaining mock engine code.
mattkae
approved these changes
Dec 16, 2024
mattkae
left a comment
mattkae
left a comment
There was a problem hiding this comment.
I have one question, but the rest of this makes sense 👍
robert-ancell
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 16, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 16, 2024
flutter/engine@0dfbd04...61616ac 2024-12-16 robert.ancell@canonical.com Migrate FlBinaryMessenger using embedder API instead of mock engine. (flutter/engine#57214) 2024-12-16 brett.morgan@gmail.com Flutter-GPU.md: Fix spelling (flutter/engine#57216) 2024-12-16 mdebbar@google.com [web] Don't close image source too early (flutter/engine#57200) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
robert-ancell
deleted the
linux-binary-messenger-test-remove-mock-engine
branch
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…lutter/engine#57214) This allows us to remove most of the remaining mock engine code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove most of the remaining mock engine code.