Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@domesticmouse
Copy link
Contributor

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@domesticmouse domesticmouse requested a review from bdero December 16, 2024 07:05
@domesticmouse domesticmouse added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2024
@auto-submit auto-submit bot merged commit b94ce44 into main Dec 16, 2024
24 checks passed
@auto-submit auto-submit bot deleted the domesticmouse-patch-1 branch December 16, 2024 19:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 16, 2024
flutter/engine@0dfbd04...61616ac

2024-12-16 robert.ancell@canonical.com Migrate FlBinaryMessenger using
embedder API instead of mock engine. (flutter/engine#57214)
2024-12-16 brett.morgan@gmail.com Flutter-GPU.md: Fix spelling
(flutter/engine#57216)
2024-12-16 mdebbar@google.com [web] Don't close image source too early
(flutter/engine#57200)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants