fix RECORD_AUDIO permission on Android when there is no permission

[agrapine]

Allows to record video without audio when we init the CameraController with enableAudio=false

 final controller = CameraController(
        camera.first,
        ResolutionPreset.high,
        enableAudio: false,
      );

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[gemini-code-assist]

Code Review

This pull request aims to fix how audio recording is handled when permissions are missing or audio is disabled. While the intent is correct, the implementation contains a critical logical error that would mute audio when it should be enabled. Additionally, the corresponding unit tests have not been updated to reflect the new logic, which would cause them to fail. I've provided a detailed review comment on the withAudioEnabled method with a suggested fix and a reference to the testing guidelines.

[agrapine]

it seems that even when we start the CameraController(enableAudio:false) when starting to record video, if no permission was given for RECORD_AUDIO on android, it just throws an exeption saying the permission wasn't granted.

[camsim99]

Wow thanks so much for catching + fixing this subtle bug!

Before we land this, we'll need to test this. You'll just need to add/modify tests in PendingRecordingTest.java.

[camsim99]

Nit: can you add a comment about the default behavior

Suggested change

	return pigeonInstance;
	// By default, the recording will not contain audio.
	return pigeonInstance;