[ci] updates update-release-info to support batch release
#10958
Conversation
| await for (final PackageEnumerationEntry entry in getPackagesToProcess()) { | ||
| if ((entry.package.parseCIConfig()?.isBatchRelease ?? false) && | ||
| (entry.package.parsePubspec().version?.isPreRelease ?? false)) { | ||
| throw UsageException( |
There was a problem hiding this comment.
note to myself, will need to add checks in #10859 to enforce this
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the update-release-info command to support batch releases. For packages configured for batch release, the command now creates a pending changelog YAML file in a pending_changelogs directory instead of directly updating the pubspec.yaml and CHANGELOG.md files. The implementation separates the logic for direct updates and batch release updates into distinct methods. A check has been added to prevent running the command on batch release packages with pre-release versions. New tests have been added to verify the batch release functionality. I have one suggestion to improve code readability.
stuartmorgan-g
changed the title
update-release-info to support batch release
| type = VersionChange.patch; | ||
| case _VersionIncrementType.build: | ||
| throw UnimplementedError( | ||
| 'Build version changes should not happen in batch mode. Please file an issue if you see this.', |
There was a problem hiding this comment.
It's not clear to me what this instruction means. If it's not supposed to happen, why should the person file an issue? What would that issue say/request?
If you mean that it's not supported, then it should say that it's not currently supported and that if that's an issue they should file an issue requesting support for build versions in batch changes.
There was a problem hiding this comment.
It can't logically happen because otherwise the tool should have throw UsageError in the earlier stage. If this line is reached, that mean something is wrong with the code
chunhtai
force-pushed
the
release-info
branch
from
4afcd4c to
892b9cc
Compare
chunhtai
force-pushed
the
release-info
branch
from
a44d965 to
e3d2c70
Compare
chunhtai
added
the
autosubmit
|
autosubmit label was removed for flutter/packages/10958, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
chunhtai
added
the
autosubmit
flutter/packages@1e50195...af1d610 2026-02-12 brunocorona.alcantar@gmail.com [video_player_avfoundation] Fix regression where http headers were ignored (flutter/packages#10991) 2026-02-12 47866232+chunhtai@users.noreply.github.com [ci] Adds more ci checks for batch release file integrity (flutter/packages#10859) 2026-02-12 stuartmorgan@google.com [google_maps_flutter] Create SDK 9 and 10 packages for iOS (flutter/packages#10852) 2026-02-12 katelovett@google.com Update codeowners (flutter/packages#11004) 2026-02-11 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 67323de to 44a626f (1372 revisions) (flutter/packages#10999) 2026-02-11 stuartmorgan@google.com [video_player] Convert iOS unit tests to Swift (flutter/packages#10989) 2026-02-11 47866232+chunhtai@users.noreply.github.com [ci] updates `update-release-info` to support batch release (flutter/packages#10958) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
As title
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3