Skip to content

[google_maps_flutter_ios] Migrate to UIScene #11001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LouiseHsu wants to merge 7 commits into
base: main
Choose a base branch
from
+36 −9
Open

[google_maps_flutter_ios] Migrate to UIScene #11001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4bcf358
lol
LouiseHsu Feb 11, 2026
c743700
init
LouiseHsu Feb 11, 2026
34be6e5
Merge branch 'main' into google-maps-ios-uiscene
LouiseHsu Feb 11, 2026
621c3ac
pubspec
LouiseHsu Feb 11, 2026
ed48870
Merge branch 'google-maps-ios-uiscene' of github.com:LouiseHsu/packag…
LouiseHsu Feb 11, 2026
c45b492
remove main?
LouiseHsu Feb 11, 2026
b802fa9
nonisolate?
LouiseHsu Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_ios/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.17.3

* Adds UIScene compatibility.

## 2.17.2

* Fixes a regression in custom marker icon handling.
Expand Down
7 changes: 5 additions & 2 deletions packages/google_maps_flutter/google_maps_flutter_ios/example/ios/Runner/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,18 @@ import GoogleMaps
import UIKit

@main
@objc class AppDelegate: FlutterAppDelegate {
@objc class AppDelegate: FlutterAppDelegate, FlutterImplicitEngineDelegate {
override func application(
_ application: UIApplication,
didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
) -> Bool {
var mapsApiKey = ProcessInfo.processInfo.environment["MAPS_API_KEY"] ?? "YOUR KEY HERE"
GMSServices.provideAPIKey(mapsApiKey)

GeneratedPluginRegistrant.register(with: self)
return super.application(application, didFinishLaunchingWithOptions: launchOptions)
}

nonisolated func didInitializeImplicitFlutterEngine(_ engineBridge: FlutterImplicitEngineBridge) {
Copy link
Contributor Author

@LouiseHsu LouiseHsu Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had to add "nonisolated" to get rid of

/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/example/ios/Runner/AppDelegate.swift:20:7

Not sure if related to flutter/flutter#181033

Copy link
Contributor

@LongCatIsLooong LongCatIsLooong Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message doesn't seem to be complete.

The FlutterImplicitEngineDelegate protocol should be main actor isolated, so this method shouldn't be nonisolated (as the caller guarantees it will be called on the main queue).

Since this is an example app, maybe turn off concurrency checking for now? Change the flag specified here to minimal: https://www.swift.org/documentation/concurrency/

You can also do an isolated conformance but I suspect when we properly mark FlutterImplicitEngineBridge as main actor isolated it will be source breaking again.

GeneratedPluginRegistrant.register(with: engineBridge.pluginRegistry)
}
}
21 changes: 21 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_ios/example/ios/Runner/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,26 @@
<true/>
<key>UIApplicationSupportsIndirectInputEvents</key>
<true/>
<key>UIApplicationSceneManifest</key>
<dict>
<key>UIApplicationSupportsMultipleScenes</key>
<false/>
<key>UISceneConfigurations</key>
<dict>
<key>UIWindowSceneSessionRoleApplication</key>
<array>
<dict>
<key>UISceneClassName</key>
<string>UIWindowScene</string>
<key>UISceneDelegateClassName</key>
<string>FlutterSceneDelegate</string>
<key>UISceneConfigurationName</key>
<string>flutter</string>
<key>UISceneStoryboardFile</key>
<string>Main</string>
</dict>
</array>
</dict>
</dict>
Comment on lines +52 to +72
Copy link

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation of the UIApplicationSceneManifest block is incorrect. This can make the file harder to read and potentially cause issues with some XML parsers. I've suggested a fix to align it with the standard plist format.

	<key>UIApplicationSceneManifest</key>
	<dict>
		<key>UIApplicationSupportsMultipleScenes</key>
		<false/>
		<key>UISceneConfigurations</key>
		<dict>
			<key>UIWindowSceneSessionRoleApplication</key>
			<array>
				<dict>
					<key>UISceneClassName</key>
					<string>UIWindowScene</string>
					<key>UISceneDelegateClassName</key>
					<string>FlutterSceneDelegate</string>
					<key>UISceneConfigurationName</key>
					<string>flutter</string>
					<key>UISceneStoryboardFile</key>
					<string>Main</string>
				</dict>
			</array>
		</dict>
	</dict>

</dict>
</plist>
4 changes: 2 additions & 2 deletions packages/google_maps_flutter/google_maps_flutter_ios/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ description: Demonstrates how to use the google_maps_flutter plugin.
publish_to: none

environment:
sdk: ^3.9.0
flutter: ">=3.35.0"
sdk: ^3.10.0
flutter: ">=3.38.0"

dependencies:
cupertino_icons: ^1.0.5
Expand Down
3 changes: 1 addition & 2 deletions ...s_flutter_ios/ios/google_maps_flutter_ios/Sources/google_maps_flutter_ios/FGMImageUtils.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@
// Refer to the flutter google_maps_flutter_platform_interface package for details.
FGMPlatformBitmapBytes *bitmapBytes = bitmap;
@try {
CGFloat mainScreenScale = [[UIScreen mainScreen] scale];
image = [UIImage imageWithData:bitmapBytes.byteData.data scale:mainScreenScale];
image = [UIImage imageWithData:bitmapBytes.byteData.data scale:screenScale];
} @catch (NSException *exception) {
@throw [NSException exceptionWithName:@"InvalidByteDescriptor"
reason:@"Unable to interpret bytes as a valid image."
Expand Down
6 changes: 3 additions & 3 deletions packages/google_maps_flutter/google_maps_flutter_ios/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ name: google_maps_flutter_ios
description: iOS implementation of the google_maps_flutter plugin.
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_ios
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
version: 2.17.2
version: 2.17.3

environment:
sdk: ^3.9.0
flutter: ">=3.35.0"
sdk: ^3.10.0
flutter: ">=3.38.0"

flutter:
plugin:
Expand Down
Loading