Skip to content

Add missing map types #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add missing map types #71

wants to merge 2 commits into from
+17 −1

Conversation

nikodembernat
Copy link

@nikodembernat nikodembernat commented Jan 16, 2025 •
edited
Loading

Added missing map types to the MapType enum.

Pre-launch Checklist

  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making if a test is possible.
  • All existing and new tests are passing.

@nikodembernat
Add missing map types
562a9f2 
Signed-off-by: Nikodem Bernat <n.bernat@outlook.com>
@nikodembernat
Bump version
6f3173a 
Signed-off-by: Nikodem Bernat <n.bernat@outlook.com>
@nikodembernat
Copy link
Author

Hi guys! @renefloor @koozz

I added missing map types and signed the commit, so you can merge it if you have some time.
Thanks a lot

@koozz koozz requested a review from renefloor January 16, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renefloor renefloor Awaiting requested review from renefloor

1 more reviewer

@tobiasleijs tobiasleijs tobiasleijs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikodembernat @tobiasleijs