feat: grow alloc #17
Open
feat: grow alloc #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the first set of tests for grow alloc. I will be adding more tests and updating the PR Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
test-grow-allocate
branch
from
97adcc6 to
7977dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first set of tests for grow alloc. I will be adding more tests and updating the PR.
Corresponding flux-sched PR to track: flux-framework/flux-sched#1340
Note: will need to figure out how to "attach" in go.
Update - attach (and the entire command file!) is actually run via the resource utility that is provided in the resource module. So if we can reproduce the logic in there (in Go code, given that it is possible to use those same functions) we can make our own attach, etc. functions.