Fix bad link in governance/ doc #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bad link is currently visible here: https://deploy-preview-1573--fluxcd.netlify.app/governance/#meetings |
This was referenced Aug 16, 2023
makkes
approved these changes
Aug 16, 2023
|
I was getting link blindness, and this was the last of about 150 links I fixed yesterday... I didn't even think to look for it there 😂 Maybe we should just link directly to that, with an absolute link? |
/governance/#meetings -> https://github.com/fluxcd/flux2#events Signed-off-by: Kingdon Barrett <kingdon@weave.works>
|
There, that will fix it just as well. No, I do think we should leave the README intact in the community repo The goal of these updates for the PR was only to fix links with minimal structural changes. If you find any links I've replaced in fluxcd/website#1573 or friends had a more direct analogue, more obvious intended target than whatever I've corrected the links to point at, let's use that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joining:
Closing this issue (and the related issues linked above) will enable us to add testing of internal links in the future, to prevent these types of issues on website from regressing.