Add mewzherder to Flux Community Maintainers #342
Conversation
|
There are some issues, I'm thinking somehow branches got mixed up - did you mean to make updates to SUPPORT.md in this PR? I can help resolve this, and it says I've got permission to edit the branch. Let's talk off thread and figure out out. Will touch base at our next check-in to determine if there's meant to be a separate PR, or if these changes got included by mistake. We should only include the relevant changes in this PR – update to the MAINTAINERS file, and COMMUNITY.md - we should also be sure to remove your entry in the PROJECT-MEMBERS.md since otherwise you'll probably appear in both lists, and I don't think we want that. 🎉 welcome to the team (though it seems a bit strange to say this as if you haven't been notionally on this team even longer than myself!) |
|
It looks like that commit was from a stale branch that had already been merged. It dropped out, so there's no DCO issue, so I can approve this and merge it now (except the discussion is in #341 and I think we are still waiting on a few maintainer approvals there) It's an LGTM from me, as soon as the appropriate approvals are done in the discussion 👍 |
|
@kingdonb thx! who / what steps are next to merge? |
|
I reviewed PROCESS.md near this section:
First it says we need all the active maintainers in the same repo (community) to vote, then a core maintainer (not me) must approve the PR - here is the relevant section: https://github.com/fluxcd/community/blob/main/PROCESS.md#applying-for-flux-maintainership I will check if all maintainers have voted and ping whomever we are missing then we can move on to the next step. |
COMMUNITY.md
Outdated
| | Tamao Nakahara | `@tamao` | `@mewzherder` | Weaveworks | | ||
| | Kingdon Barrett | `@KingdonB` | `@kingdonb` | Weaveworks | | ||
| | Tamao Nakahara | `@tamao` | `@mewzherder` | Independent | | ||
| | Kingdon Barrett | `@KingdonB` | `@kingdonb` | Independent | |
There was a problem hiding this comment.
@kingdonb this should go into a diffrent PR. Also the commits to this PR should be made Tamao and signed by her.
There was a problem hiding this comment.
I think we tried using the GitHub UI and it went horribly wrong. I'll confer with Tamao and put the community affiliation changes in a separate PR 👍
There was a problem hiding this comment.
GitHub UI works Ok, but first you need to delete the fork to start fresh, the UI also allows signoff.
There was a problem hiding this comment.
I put the affiliation changes for COMMUNITY.md into #345 - they are separate now
We will still need to add @mewzherder sign-off and signature, (or is only sign-off enough?)
You should be able to add your sign-off with git commit --amend --sign-off so you get authorship on the commit, or you could close this PR and try a new one. I don't know if you want to try git pull --rebase -- it might just work?
There was a problem hiding this comment.
I removed my sign-off so the DCO bot shows the check missing properly, so it's clearer what we are talking about.
I think it will be easier for Tamao to delete the fork and start over like you say 👍
kingdonb
force-pushed
the
patch-1
branch
2 times, most recently
from
30f716c
to
8860176
Compare
Signed-off-by: Tamao Nakahara <tamaonakahara@gmail.com>
|
I think we resolved all the issues in this PR, @stefanprodan can you confirm |
Membership from: #341