Add shortcode for calendar table #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file on the main branch here winds up rendered in the website as COMMUNITY.md thanks to external-sources configuration. It should be possible to get a deploy preview to use the add-calendar-table branch temporarily? WIP / draft commit Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
1 task
kingdonb
added a commit
to fluxcd/website
that referenced
this pull request
Apr 24, 2024
Let's add a branch ref for external-sources (to temporarily enable previews of fluxcd/community#396) Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
kingdonb
added a commit
to fluxcd/website
that referenced
this pull request
Apr 24, 2024
Let's add a branch ref for external-sources (to temporarily enable previews of fluxcd/community#396) Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
kingdonb
force-pushed
the
add-calendar-table
branch
2 times, most recently
from
351e39f
to
c7a7296
Compare
kingdonb
changed the title
kingdonb
commented
Apr 24, 2024
|
|
||
| Do note that Daylight Savings Time changes can vary across regions, which can cause some confusion. | ||
|
|
||
| The calendar at <https://fluxcd.io/community#meetings> has been localized to show the events in your local time zone. |
There was a problem hiding this comment.
This link is really for the benefit of anyone that happens to be reading this file at https://github.com/fluxcd/community/?tab=readme-ov-file#joining-the-flux-community - since they may not be aware this README.md file is used as an external-source and that the README here actually drives the website page fluxcd.io/community.
Probably all of the Flux maintainers who would review this PR already knew that, but...
kingdonb
added a commit
to fluxcd/website
that referenced
this pull request
May 2, 2024
Let's add a branch ref for external-sources (to temporarily enable previews of fluxcd/community#396) Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
* fix calendar formatting * fix link formatting * remove color="dark" * remove blocks/section type="calendar-row" * the fluxcd/website repo also got some formatting changes in 2c5d1e4a * Move sentence from the calendar template * The home/calendar shortcode had this sentence in it * fewer line breaks * one additional line break * overhaul the text some more * overhaul text again * fix up formatting in table Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
* less text * s/Uneven/Odd/ Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
kingdonb
force-pushed
the
add-calendar-table
branch
from
450e828
to
5d3ac2f
Compare
|
The deploy preview at https://docs-fluxcd-website-6lrhgsuf.fermyon.app/ is current This PR (this one) needs to merge first: #396 |
stefanprodan
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file on the main branch here winds up rendered in the website as COMMUNITY.md thanks to external-sources configuration.
It should be possible to get a deploy preview to use the add-calendar-table branch temporarily?
The changes can be reviewed now, I should take one more pass at copy editing but someone else could also do it.
I've also added the Flux Bug Scrub to the Recurring Events table here. I think we should keep the Schedule table because it mentions the time zone that events are scheduled in, which isn't done anywhere else.
This is important for attendees to be aware of basically only when DST changes occur (since you may be in Europe and DST in US time changes versus your home time zone happen about a week apart, or vice versa.)
I could be convinced to remove it if we can somehow make the "subscribe" callout way more prominent, because most people are not subscribing to the Flux calendar. Also may be this schedule section is just no longer necessary, because we actually solved it with the Javascript time localization. (I do want to encourage more community members to host scheduled meetings though, and since this callout section draws attention to them specially, I would fight to keep it.)