Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add maxConcurrentCanaries flag to limit concurrent progressing canaries #1568

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add maxConcurrentCanaries flag to limit concurrent progressing canaries #1568

wants to merge 1 commit into from

Conversation

louishalbritter
Copy link

This adds a flag to limit concurrent progessing canaries to avoid high requests of resources at once.

The flag will not take effect if set to "0", which is default.

Closes #1069

@louishalbritter louishalbritter force-pushed the limit-concurrent-canaries branch from fb1f5b5 to bec06ec Compare December 11, 2023 17:29
@stefanprodan
Copy link
Member

Please rebase with main and force push instead of merging, this PR should have a single commit.

@louishalbritter louishalbritter force-pushed the limit-concurrent-canaries branch 2 times, most recently from 365fa1d to 5dd58b7 Compare February 8, 2024 12:29
@louishalbritter louishalbritter force-pushed the limit-concurrent-canaries branch from 00af576 to 03cfb87 Compare March 12, 2024 08:44
@louishalbritter louishalbritter force-pushed the limit-concurrent-canaries branch from 29fd239 to 8b6cf92 Compare May 29, 2024 08:46
@louishalbritter
Copy link
Author

I cleaned to git history up again. Can you please merge or deny this pull request?

@aryan9600
Copy link
Member

hey @louishalbritter, sorry this has been pending for a long time. i'll try to take a look this week. generally, we try to avoid making changes to the pkg/controller/scheduler.go. the code in there is the backbone of flagger and is very complicated, one small change can break the entire state machine. i'll need some time to review and test this, while trying to confirm that its not possible to implement this without making changes there.

@louishalbritter
Copy link
Author

Thank you. I totally understand this.
We're running this change since month in production and didn't have any problems with it.
Let me know if I can support you somehow.

@louishalbritter louishalbritter force-pushed the limit-concurrent-canaries branch 2 times, most recently from c524bee to eedb8e8 Compare September 9, 2024 08:26
@louishalbritter louishalbritter force-pushed the limit-concurrent-canaries branch from eedb8e8 to 5b10ac1 Compare December 17, 2024 11:13
@louishalbritter
add maxConcurrentCanaries flag to limit concurrent progressing canaries
c4231e2 
This adds a flag to limit concurrent progessing canaries to avoid high
requests of resources at once.

The flag will not take effect if set to "0", which is default.

Closes fluxcd#1069

Signed-off-by: Louis Halbritter <halbritter@posteo.de>

chore: update Helm default values and README

Signed-off-by: Louis Halbritter <halbritter@posteo.de>
@louishalbritter louishalbritter force-pushed the limit-concurrent-canaries branch 2 times, most recently from aee2303 to c4231e2 Compare December 17, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan left review comments

@aryan9600 aryan9600 Awaiting requested review from aryan9600 aryan9600 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit concurrent processing canaries
3 participants
@louishalbritter @stefanprodan @aryan9600