Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spec.suspend to Kustomization printer columns #561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schrej
Copy link

@schrej schrej commented Feb 4, 2022

This adds spec.suspend to the default columns of Kustomization.

It's currently hard to find Kustomizations that are suspended, and I think that's a pretty common use-case when leveraging that feature.
It's currently a default column as it's pretty slim anyway, but it could also be set to only show for -o wide.

The PR also moves the Status column to the end, after Age, since the messages are very long in error cases, which makes the columns behind it hard to find, and breaks up the table header as well.

@schrej schrej force-pushed the kustomization-columns-suspended branch from 14a841c to 2797519 Compare February 4, 2022 13:38
@stefanprodan
Copy link
Member

flux get kustomization does have the suspended field and the Git SHAs are trimmed. Any reason for not using Flux CLI?

@schrej schrej changed the title add spec.suspended to Kustomization printer columns add spec.suspend to Kustomization printer columns Feb 4, 2022
@schrej
Copy link
Author

schrej commented Feb 4, 2022

Oh, true, I forgot that flux get exists 😬
But it's just a habit (in my case) to use kubectl as the primary method for interacting with resources, and I'd argue that it would be more convenient like this.

Signed-off-by: Jakob Schrettenbrunner <jakob.schrettenbrunner@telekom.de>
@schrej schrej force-pushed the kustomization-columns-suspended branch from 2797519 to b2b3f7a Compare February 4, 2022 13:41
@stefanprodan
Copy link
Member

stefanprodan commented Feb 4, 2022

The suspend field is preset in almost all Flux APIs. Please open an issue in flux2 with a proposal to change this in a consistent manner. If the maintainers of all Flux controllers are supportive of this change, then we need to open PRs everywhere and ship this as a whole in the next Flux minor release.

@stefanprodan stefanprodan added the hold Issues and pull requests put on hold label Feb 4, 2022
@ntx-ben
Copy link

ntx-ben commented Oct 12, 2023

Looking forward to this as well. We use k9s extensively and having the suspended column would be very helpful!

@jflambert
Copy link

flux get kustomization does have the suspended field and the Git SHAs are trimmed. Any reason for not using Flux CLI?

would help with k9s integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Issues and pull requests put on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants