Skip to content

Commit

Permalink
Merge pull request #1575 from fparga/patch-1
Browse files Browse the repository at this point in the history
fix regex example in flux notification for helm release promotion
  • Loading branch information
stefanprodan authored Jul 20, 2023
2 parents 0f6f184 + 6c6c656 commit 07cd56a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions content/en/flux/use-cases/gh-actions-helm-promotion.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,13 @@ spec:
- kind: HelmRelease
name: demo
inclusionList:
- "*.upgrade.*succeeded.*"
- ".*.upgrade.*succeeded.*"
```

**Note** that you should adapt the above definitions to match your GitHub repository address.
If [testing is enabled](https://fluxcd.io/flux/components/helm/helmreleases/#configuring-helm-test-actions)
in your HelmRelease, you can use the `"*.test.*succeeded.*"`
expression in the inclusion list instead of `"*.upgrade.*succeeded.*"`.
in your HelmRelease, you can use the `".*.test.*succeeded.*"`
expression in the inclusion list instead of `".*.upgrade.*succeeded.*"`.
This will ensure the promotion happens only after tests have been successfully run.

You also need to create a Kubernetes secret with a GitHub Personal Access Token
Expand Down

0 comments on commit 07cd56a

Please sign in to comment.