Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename signals to be more descriptive #2359

Closed
wants to merge 2 commits into from
Closed

Conversation

DariaKunoichi
Copy link
Contributor

@DariaKunoichi DariaKunoichi commented Jul 11, 2023

Description of change

Closes: GH-2196

Checklist
  • Tested in playground or other setup
  • Screenshot (Grafana) from playground added to PR for 15+ minute run
  • Documentation is changed or added
  • Tests and/or benchmarks are included
  • Breaking changes

Summary by CodeRabbit

Refactor:

  • Renamed signal names from 'SIGNAL' to 'LATENCY' and 'SIGNAL_LONG_TERM' to 'LATENCY_LONG_TERM' across multiple files for better clarity and understanding.

🎉 With a name change, clear as day, 🌞

'SIGNAL' to 'LATENCY', we pave the way. 🛣️

'LONG_TERM' too joins the fray, 🏁

Making our code more intuitive, hooray! 🥳

@DariaKunoichi DariaKunoichi self-assigned this Jul 11, 2023
@DariaKunoichi DariaKunoichi requested review from a team as code owners July 11, 2023 13:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 11, 2023

Image description CodeRabbit

High-Level Summary

The changes in this pull request primarily involve renaming of signal names across multiple files. The signal names 'SIGNAL' and 'SIGNAL_LONG_TERM' have been renamed to 'LATENCY' and 'LATENCY_LONG_TERM' respectively. These modifications are cosmetic and do not impact the underlying logic or functionality of the code.

Files Summary
blueprints/load-scheduling/average-latency/policy.libsonnet, blueprints/load-scheduling/common/policy.libsonnet, blueprints/load-scheduling/promql/policy.libsonnet Signal names 'SIGNAL' and 'SIGNAL_LONG_TERM' have been renamed to 'LATENCY' and 'LATENCY_LONG_TERM'. This is a cosmetic change and does not affect the code's logic or functionality.

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @coderabbitai: ignore anywhere in the PR description to ignore further reviews from the bot.

Files ignored due to filter (24)

Ignored files

  • docs/content/use-cases/adaptive-service-protection/assets/average-latency-feedback/graph.mmd
  • docs/content/use-cases/adaptive-service-protection/assets/average-latency-feedback/graph.mmd.md5sum
  • docs/content/use-cases/adaptive-service-protection/assets/average-latency-feedback/graph.mmd.svg
  • docs/content/use-cases/adaptive-service-protection/assets/average-latency-feedback/policy.yaml
  • docs/content/use-cases/adaptive-service-protection/assets/workload-prioritization/graph.mmd
  • docs/content/use-cases/adaptive-service-protection/assets/workload-prioritization/graph.mmd.md5sum
  • docs/content/use-cases/adaptive-service-protection/assets/workload-prioritization/graph.mmd.svg
  • docs/content/use-cases/adaptive-service-protection/assets/workload-prioritization/policy.yaml
  • docs/content/use-cases/auto-scaling/assets/load-based-auto-scaling/graph.mmd
  • docs/content/use-cases/auto-scaling/assets/load-based-auto-scaling/graph.mmd.md5sum
  • docs/content/use-cases/auto-scaling/assets/load-based-auto-scaling/graph.mmd.svg
  • docs/content/use-cases/auto-scaling/assets/load-based-auto-scaling/policy.yaml
  • operator/config/samples/fluxninja.com_v1alpha1_policy.yaml
  • playground/scenarios/basic-service-protection/policies/basic-service-protection-cr.yaml
  • playground/scenarios/demo-app-fan-in/policies/weighted-service-protection-cr.yaml
  • playground/scenarios/graceful-js/policies/workload-prioritization-cr.yaml
  • playground/scenarios/java-service-protection/policies/service-protection-cr.yaml
  • playground/scenarios/prometheus-workload-prioritization/policies/prometheus-workload-prioritization-cr.yaml
  • playground/scenarios/rabbitmq-queue-buildup/policies/service1-demoapp-rabbitmq-queue-buildup-cr.yaml
  • playground/scenarios/service-protection-auto-scale-escalation/policies/load-based-auto-scale-cr.yaml
  • playground/scenarios/service-protection-rl-escalation-kong/policies/service1-demo-app-cr.yaml
  • playground/scenarios/service-protection-rl-escalation-nginx/policies/service1-demo-app-cr.yaml
  • playground/scenarios/service-protection-rl-escalation/policies/service1-demo-app-cr.yaml
  • playground/scenarios/workload-prioritization/policies/workload-prioritization-cr.yaml

In the recent run, only the files that changed from the base of the PR and between 54d6e748cf3e05b4f8dbcb94b17753263403a1d9 and ed9eb1e7325e7662b09b00831f9eb18cec57c73a commits were reviewed.

Files not reviewed due to simple changes (3)

Skipped review in the recent run

  • blueprints/load-scheduling/average-latency/policy.libsonnet
  • blueprints/load-scheduling/common/policy.libsonnet
  • blueprints/load-scheduling/promql/policy.libsonnet

@DariaKunoichi DariaKunoichi deleted the signal_names branch August 9, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename signals to be more descriptive
3 participants