-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cond): a380 temperature control and ventilation #8086
feat(cond): a380 temperature control and ventilation #8086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
fbw-common/src/wasm/systems/systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-common/src/wasm/systems/systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-common/src/wasm/systems/systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-common/src/wasm/systems/systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-common/src/wasm/systems/systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-a380x/src/wasm/systems/a380_systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-a380x/src/wasm/systems/a380_systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-a380x/src/wasm/systems/a380_systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-a380x/src/wasm/systems/a380_systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-a380x/src/wasm/systems/a380_systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
Thanks for the review @Gurgel100 ! It's taken a while but all comments should've been addressed now. Really good suggestions as always! 😄 🚀 |
fbw-common/src/wasm/systems/systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-common/src/wasm/systems/systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-common/src/wasm/systems/systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-common/src/wasm/systems/systems/src/air_conditioning/mod.rs
Outdated
Show resolved
Hide resolved
fbw-common/src/wasm/systems/systems/src/air_conditioning/acs_controller.rs
Show resolved
Hide resolved
fbw-common/src/wasm/systems/systems/src/air_conditioning/acs_controller.rs
Outdated
Show resolved
Hide resolved
...rc/wasm/systems/a380_systems/src/air_conditioning/local_controllers/trim_air_drive_device.rs
Outdated
Show resolved
Hide resolved
...rc/wasm/systems/a380_systems/src/air_conditioning/local_controllers/trim_air_drive_device.rs
Outdated
Show resolved
Hide resolved
...rc/wasm/systems/a380_systems/src/air_conditioning/local_controllers/trim_air_drive_device.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Only some more remarks.
fbw-common/src/wasm/systems/systems/src/air_conditioning/acs_controller.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
Summary of Changes
This PR finishes the first iteration of the Air Conditioning system for the A380. It adds:
The temperature simulation and heat exchange will still need to be adjusted later on for accuracy when we can load passengers and do full flights, but this should provide a foundation with all pieces in place.
Screenshots (if necessary)
I created this to help whoever wants to work on the COND SD page 😉
References
Additional context
As per the A320 air cond system, this doesn't incorporate failures, although most elements can be "failed" by removing power.
It also doesn't include avionics ventilation.
Discord username (if different from GitHub):
Testing instructions
As per #7960 this shouldn't have any effect on the A320. A quick courtesy test that everything works would be much appreciated but shouldn't be required.
If you want to test this in the A380, you should use the air-cond-system branch.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.