Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cond): a380 temperature control and ventilation #8086

Merged
merged 29 commits into from
Oct 20, 2023

Conversation

mjuhe
Copy link
Contributor

@mjuhe mjuhe commented Jun 24, 2023

Summary of Changes

This PR finishes the first iteration of the Air Conditioning system for the A380. It adds:

  • CPIOM B Applications:
    • Temperature Control System Application
    • Ventilation Control System Application
  • Local controllers:
    • Trim Air Drive Device (TADD)
    • Ventilation Control Module (VCM FWD and AFT)
  • Other elements and features:
    • Bulk Cargo Heater
    • High Pressure cabin fans
    • Isolation Valves for FWD and BULK Cargo compartments

The temperature simulation and heat exchange will still need to be adjusted later on for accuracy when we can load passengers and do full flights, but this should provide a foundation with all pieces in place.

Screenshots (if necessary)

I created this to help whoever wants to work on the COND SD page 😉

image

References

Additional context

As per the A320 air cond system, this doesn't incorporate failures, although most elements can be "failed" by removing power.
It also doesn't include avionics ventilation.

Discord username (if different from GitHub):

Testing instructions

As per #7960 this shouldn't have any effect on the A320. A quick courtesy test that everything works would be much appreciated but shouldn't be required.

If you want to test this in the A380, you should use the air-cond-system branch.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

Copy link
Contributor

@Gurgel100 Gurgel100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@mjuhe
Copy link
Contributor Author

mjuhe commented Oct 1, 2023

Thanks for the review @Gurgel100 ! It's taken a while but all comments should've been addressed now. Really good suggestions as always! 😄 🚀

Copy link
Contributor

@Gurgel100 Gurgel100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Only some more remarks.

Copy link
Contributor

@Gurgel100 Gurgel100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@Gurgel100 Gurgel100 merged commit 581edbc into flybywiresim:master Oct 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants