refactor: unify navigraph login

[Benjozork]

Summary of Changes

• Unifies Navigraph and SimBrief login into one by default
• Moves Navigraph login UI to 3rd Party Options
• Adds option to override SimBrief user ID to use a different account than the main Navigraph account

Testing instructions

This PR cannot be tested using the normal method of downloading builds. Please check the QA channel on Discord for a build link.

1. Test out the SimBrief import without changing anything (this step requires that you have a Navigraph account already linked in the flyPad)
   • Go to Settings -> Third Party Options -> See if your navigraph account is detected.
   • Press the import button on the dashboard. Verify that it works.
2. Test out the Navigraph account login flow
   • Go to Settings -> Third Party Options -> Unlink your existing account if applicable
   • Verify button changes to allow you to link an account.
   • Press button and follow instructions on screen. Verify you are taken back to the Third Party Options page and that your account username, subscription status and "unlink account" now show.
   • Verify that you can import simbrief plans as per test 1.
3. Test out the FMS SimBrief import flow
   • Verify that you can import a SimBrief flight plan from the FMS
4. Test out the new "Override SimBrief User ID" feature
   • Go to Settings -> Third Party Options -> Enter a different user ID or SimBrief username in the field.
   • Verify it is accepted correctly.
   • Check if both EFB and FMS SimBrief import follow the overridden ID and not the linked Navigraph account.
   • Press the trash icon next to the field.
   • Check if both EFB and FMS SimBrief import follow the linked Navigraph account.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, click on the bottom PR tab
4. Click on the A32NX download link at the bottom of the page

[alepouna]

QA Report

Discord: alepouna
Object of testing: #8119
Tier of Testing : 1
Date : 12/08/2023

Testing Process:

1. Test out the Navigraph account login flow

• Verify button changes to allow you to link an account.
• Press button and follow instructions on screen. Verify you are taken back to the Third Party Options page and that your account username, subscription status and "unlink account" now show.
• Press the import button on the dashboard. Verify that it works.

2. Test out the FMS SimBrief import flow

• Verify that you can import a SimBrief flight plan from the FMS

3. Test out the new "Override SimBrief User ID" feature

• Go to Settings -> Third Party Options -> Enter a different user ID or SimBrief username in the field.
• Verify it is accepted correctly.
• Check if both EFB and FMS SimBrief import follow the overridden ID and not the linked Navigraph account.
• Press the trash icon next to the field.
• Check if both EFB and FMS SimBrief import follow the linked Navigraph account.

3. Test out the SimBrief import without changing anything (this step requires that you have a Navigraph account already linked in the flyPad)

• Go to Settings -> Third Party Options -> See if your navigraph account is detected.
• Press the import button on the dashboard. Verify that it works.

Testing Results:
Passed

Notes:
When loading for the first time, due to the option "Auto-Import SimBrief" being on, every time you load into the plane you get an 'Unknown ID' popup error on the EFB. This is probably out of the scope of the PR, but perhaps the setting could be disabled if a Navigraph data/SimBrief ID, gets removed

[brewers10]

Quality Assurance Tester Report

Discord: brewers_10#5706
Object of testing: #8119
Tier of Testing: 1
Date: 13/08/2023

Testing Process:

1. Test out the SimBrief import without changing anything (this step requires that you have a Navigraph account already linked in the flyPad).

• Go to Settings -> Third Party Options -> See if your navigraph account is detected. [PASS]

• Press the import button on the dashboard. Verify that it works. [PASS]

2.Test out the Navigraph account login flow

• Go to Settings -> Third Party Options -> Unlink your existing account if applicable [PASS]

• Verify button changes to allow you to link an account. [PASS]

• Press button and follow instructions on screen. Verify you are taken back to the Third Party Options page and that your account username, subscription status and "unlink account" now show. [PASS]

• Verify that you can import simbrief plans as per test 1. [PASS]

3. Test out the FMS SimBrief import flow

• Verify that you can import a SimBrief flight plan from the FMS [PASS]

4. Test out the new "Override SimBrief User ID" feature

• Go to Settings -> Third Party Options -> Enter a different user ID or SimBrief username in the field. [PASS]

• Verify it is accepted correctly. [PASS]

• Check if both EFB and FMS SimBrief import follow the overridden ID and not the linked Navigraph account. [FAIL]

• Press the trash icon next to the field. [PASS]

• Check if both EFB and FMS SimBrief import follow the linked Navigraph account. [PASS]

Negatives:
When using the overridden Simbrief ID the Simbrief uplink on the EFB was still using the linked account flightplan, not the overridden one. FMS uplink worked however.

Testing Results:
Failed

Conclusions:
Just that one issue.

[alepouna]

QA Report

Discord: alepouna
Object of testing: #8119
Tier of Testing : 1
Date : 19/08/2023

Testing Process:

1. Test out the Navigraph account login flow

• Verify button changes to allow you to link an account.
• Press button and follow instructions on screen. Verify you are taken back to the Third Party Options page and that your account username, subscription status and "unlink account" now show.
• Press the import button on the dashboard. Verify that it works.

2. Test out the FMS SimBrief import flow

• Verify that you can import a SimBrief flight plan from the FMS

3. Test out the new "Override SimBrief User ID" feature

• Go to Settings -> Third Party Options -> Enter a different user ID or SimBrief username in the field.
• Verify it is accepted correctly.
• [FAIL] Check if both EFB and FMS SimBrief import follow the overridden ID and not the linked Navigraph account.
• Press the trash icon next to the field.
• Check if both EFB and FMS SimBrief import follow the linked Navigraph account.

3. Test out the SimBrief import without changing anything (this step requires that you have a Navigraph account already linked in the flyPad)

• Go to Settings -> Third Party Options -> See if your navigraph account is detected.
• Press the import button on the dashboard. Verify that it works.

Testing Results:
Not Passed

Negatives:
After doing a retest, if you add a simbrief override and then a Navi link, you will get a correct FMS & EFB import. However if you do it the other way around (Navi link -> Override) you will get a correct FMS but not a correct EFB import. I was able to replicate this 2/4 times testing this.

Notes:
Same as my previous QA test

[Valastiri]

Can anyone provide a sample screenshot of the integration fields / pages for documentation purposes? You can pass them to me in Discord and/or strip personal information if required.

You can also send things into the docs PR directly linked below.

Thanks in advance.

• refactor(simbrief): navigraph and simbrief changes docs#876

[Saschl]

QA Report

1. [Partially passed] Test out the SimBrief import without changing anything (this step requires that you have a Navigraph account already linked in the flyPad)

2. [PASSED] Test out the Navigraph account login flow

   • Go to Settings -> Third Party Options -> Unlink your existing account if applicable
   • Verify button changes to allow you to link an account.
   • Press button and follow instructions on screen. Verify you are taken back to the Third Party Options page and that your account username, subscription status and "unlink account" now show.
   • Verify that you can import simbrief plans as per test 1.

3. [PASSED] Test out the FMS SimBrief import flow

   • Verify that you can import a SimBrief flight plan from the FMS

4. {PASSED] Test out the new "Override SimBrief User ID" feature

   • Go to Settings -> Third Party Options -> Enter a different user ID or SimBrief username in the field.
   • Verify it is accepted correctly.
   • Check if both EFB and FMS SimBrief import follow the overridden ID and not the linked Navigraph account.
   • Press the trash icon next to the field.
   • Check if both EFB and FMS SimBrief import follow the linked Navigraph account.

Remarks:

1. Works very nicely but one potential issue: if navigraph account is not linked, but simbrief user id was entered, I'm getting following error. After re-entering userId/username it works fine.

Verified in discord that this behaviour is fine.

Testing Results:
Passed