Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apu): Added xfeed APU capabilities #8216

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Conversation

Taz5150
Copy link
Contributor

@Taz5150 Taz5150 commented Sep 15, 2023

Fixes #[issue_no]

Summary of Changes

This PR fixes/ adds cross feed APU fuel capabilities.

With xfeed OFF, APU will always burn fuel from the left tank.
With xfeed ON, APU burns fuel from both tanks as per the table below

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub): TazX [Z+1]#405

Testing instructions

Starting with the aircraft C&D:

  1. Proceed to start the APU
  2. Press Xfeed PB to ON
  3. Check fuel is burnt from both Left & Right tanks
  4. Turn both Left fuel pumps OFF; check fuel is burnt from Right tank
  5. Turn both Left pumps ON
  6. Turn both Right pumps OFF; check fuel is burnt from Left tank
  7. Turn all fuel pumps OFF; check fuel is burnt from both Left & Right tanks

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Taz5150 Taz5150 requested a review from donstim September 15, 2023 07:42
@@ -1292,4 +1307,4 @@ class EngineControl {
}
};

EngineControl EngineControlInstance;
EngineControl EngineControlInstance;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make the text file invalid by removing the last line feed? :P

@donstim
Copy link
Contributor

donstim commented Sep 15, 2023

LGTM

@2hwk 2hwk added this to the v0.11.0 milestone Sep 16, 2023
@2hwk 2hwk added the QA Tier 1 label Sep 16, 2023
@2hwk
Copy link
Member

2hwk commented Sep 16, 2023

Needs modification to account for fuel burn when left and right pumps are off (see discussion in #development)

@Taz5150
Copy link
Contributor Author

Taz5150 commented Sep 19, 2023

Needs modification to account for fuel burn when left and right pumps are off (see discussion in #development)

After some discussion in #development, I have updated the code as per the following table:

image

@BlueberryKing
Copy link
Member

Dev Team Report

Discord : BlueberryKing
Object of testing: 8216
Tier of Testing : 1
Date : 14/10/2023

Testing Process:
I checked some fuel flow values by making sure the values on the SD page went down, but later just looked at the simvar values because the process was very slow.

  • Start C&D
  • Proceed to start the APU
  • Press Xfeed PB to ON
  • Checked fuel is burnt from both Left & Right tanks
  • Turned both Left fuel pumps OFF; checked that fuel is burnt from Right tank
  • Turned both Left pumps ON
  • Turned both Right pumps OFF; checked that fuel is burnt from Left tank
  • Turned all fuel pumps OFF; checked fuel is burnt from both Left & Right tanks

Testing Results:
Passed

Media:
N/A

Conclusion:
LGTM!

@Saschl Saschl enabled auto-merge (squash) October 20, 2023 12:59
@Saschl Saschl merged commit 817cc8c into flybywiresim:master Oct 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

6 participants