fix(pfd): Improve FMA font size, mode change box & positions #8235

BravoMike99 · 2023-09-28T22:52:35Z

Fixes #8218

Summary of Changes

Reduce armed FMA font size
Adjust CLB armed position in accordance with newer DMC standards
Adjust mode change FMA box for first, second and third column FMAs
Adjust THR IDLE and V/S FPA FMA active font size
Hide '+' sign on V/S & FPA FMAs if selected value is zero
Reworked FLX FMA and "MAN" text position in MAN THR/MAN MCT/MAN TOGA

Screenshots (if necessary)

Left = new, right = old

References

Provided in the original issue, youtube videos and some others in private provided by @becas22 .

Additional context

Initially this PR was only aimed to fix #8218 but during development a few issues were spotted in the FMA with @becas22 help.
I also spotted some other FMA issues while working in this PR (AB armed position for e.g., vertical positioning on some etc. ) which I might touch on another PR. As such, the main idea of this PR was to improve some stuff while not making any big regressions as a direct result of these changes.

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

Fly around testing multiple FMA changes (lateral, vertical and thrust) and make sure nothing looks weird/out of place.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, click on the bottom PR tab
Click on the A32NX download link at the bottom of the page

Reverts fma font back to medium taking into account close up PFD pictures. Armed font should be the same size as AP/ATHR/FD status font.

Changes CLB alignment and font size according to closeup PFD refs.

Fixing only the AB/ATHR messages clashes with flex/toga/mct box.

Adds subject to dynamically change the font size of V/S and FPA as they are smaller IRL. This way, they fit into the box. Also adds empty space when FPA is 0

beheh · 2023-10-18T08:38:28Z

Hey there, thanks for the PR! While I don't have a specific issue, I do want to point out that the FMA layouts can vary from aircraft to aircraft due to different EIS versions, and of course it can be very different on other aircraft like A330s. So when gathering photos and references you will need to double-check that you're gathering consistent refs from a modern A320 EIS version.

For the CLB specifically it looks like #8218 indeed points out a new behaviour, so nice find & fix!

I'll also /cc @lukecologne because I believe he's taken a close look at these in the past.

lukecologne · 2023-10-18T09:27:27Z

I think that in the same versions where the CLB was centered, the armed mode font size was increased to be identical to the active modes (earlier it was much smaller), so I don't think reducing the font size is correct here. Not sure about the other changes, I'd have to compare to some more refs. As @beheh already said, you have to be careful which EIS version is installed in your refs.

BravoMike99 · 2023-10-18T22:48:27Z

I think that in the same versions where the CLB was centered, the armed mode font size was increased to be identical to the active modes (earlier it was much smaller), so I don't think reducing the font size is correct here. Not sure about the other changes, I'd have to compare to some more refs. As @beheh already said, you have to be careful which EIS version is installed in your refs.

Hi there, thank you and @beheh for the comments. I am aware of the differences that there may be with EIS/DMC versions just like how it happens on other systems (FWS/FMGS etc,), as such, I tried to make sure the changes are applicable to the target EIS standard, however, there's always the possibility of some misinterpretation. Also feel free to ping me on discord regarding any questions, I'd be glad to discuss this further.

beheh · 2023-10-25T10:01:55Z

@BravoMike99 I'm following up with somebody, I might have another ref for you. Are you targeting a specific EIS version? At this level of detail it probably makes sense to just pick one (and also update README.md with it).

I think so far we have at least S15 if not higher, as that introduces the Auto Brake FMA (I believe). S16 I think is also pretty common.

BravoMike99 · 2023-10-27T22:24:02Z

@BravoMike99 I'm following up with somebody, I might have another ref for you. Are you targeting a specific EIS version? At this level of detail it probably makes sense to just pick one (and also update README.md with it).

I think so far we have at least S15 if not higher, as that introduces the Auto Brake FMA (I believe). S16 I think is also pretty common.

Hi there. The CLB armed was introduced after S15, however, its hard for me to know which specific version introduced it due to airlines jumping versions and it not being documented in the DMC MODs provided by airbus for S15.2/16/17 & S18. S16 and S17 seem to be the more common ones indeed due to the Safety Beyond Standard retrofits going on.

beheh · 2023-11-13T10:23:41Z

I'm all for proceeding on this PR! The only enhancement that would be nice is picking an EIS version and adding it to README.md, for future consistency.

alepouna · 2023-11-18T09:14:58Z

QA Report

Discord: alepouna
Object of testing: #8235
Tier of Testing : 1
Date : 18/11/2023

Testing Process:

Fly around testing multiple FMA changes (lateral, vertical and thrust) and make sure nothing looks weird/out of place.
Notice for any issues
Notice changes look as described

Testing Results:
Passed

fbw-a32nx/src/systems/instruments/src/PFD/FMA.tsx

lukecologne · 2023-11-24T17:43:39Z

Just checked the TCAS armed mode, looks like it was shifted due to the changed font size:
Before:

After:

Real A320:

lukecologne · 2023-11-24T17:49:05Z

I took the liberty to add a small fix for this myself, hope that was ok for you:

lukecologne · 2023-11-24T17:57:48Z

Ok, I think we are good to go if you are ready @BravoMike99

BravoMike99 · 2023-11-25T13:29:57Z

Ok, I think we are good to go if you are ready @BravoMike99

All good from my side but perhaps we should bump the EIS version to something you find adequate as per beheh suggestion since the CLB centered is newer than S15. I've also been suggested by becas to touch #8217 in this PR considering there has been no more development in #8230 for a while. What do you think?

lukecologne · 2023-11-25T15:12:35Z

Ok, we just got a new ref where TCAS armed is centered. My theory is that this was actually done in the same update where CLB was also centered, since the EIS standard where the AP/FD TCAS mode was introduced is already rather old (EIS S8). I'm gonna push a quick fix for that, sorry about that.
About #8230, if you want to take that PR over, it should still be in a new PR, and you should ask in the old PR if they plan on working on that further.
And finally, we haven't made a decision in the team about the target EIS standard yet, but I mean, that can be easily updated in another PR so I wouldn't consider it a blocker. I don't think the cented CLB is newer than S15, I'm reasonably sure that it's actually at S13 or possibly earlier than that

lukecologne · 2023-11-25T15:29:14Z

Fix is pushed, this is how it looks now:

vs IRL:

beheh · 2023-11-25T15:50:34Z

Just because I brought it up, I agree: If we can't easily agree on an EIS standard let's merge as-is, as there's a bunch of really nice fixes in here. Thanks for your contributions!

BravoMike99 · 2023-11-25T16:05:10Z

Ok, we just got a new ref where TCAS armed is centered. My theory is that this was actually done in the same update where CLB was also centered, since the EIS standard where the AP/FD TCAS mode was introduced is already rather old (EIS S8). I'm gonna push a quick fix for that, sorry about that. About #8230, if you want to take that PR over, it should still be in a new PR, and you should ask in the old PR if they plan on working on that further. And finally, we haven't made a decision in the team about the target EIS standard yet, but I mean, that can be easily updated in another PR so I wouldn't consider it a blocker. I don't think the cented CLB is newer than S15, I'm reasonably sure that it's actually at S13 or possibly earlier than that

No worries. I think its newer than S15 as I have seen some planes with the autobrake FMA on the 3rd line but the CLB not centered(e.g. https://youtu.be/0B1yu7Ju7fM?t=733) . Since those were the only doubts I had remaining, all good from my side to merge then 😃

- match slats+flaps position dots to actual positions - remove speed tape outline right - remove spaces in FMA E2 cell (i.e. 1FD2 instead of 1 FD 2) - fix LS info box position (push a little bit upwards) - integrate PR flybywiresim#8235 (FMA pos. update) & flybywiresim#8214 (move trans alt/lvl to arinc bus) - make tens of digital altitude readout font smaller & push to right - altitude tape now listens to baro corrected altitude

* - import Arinc429Word from fbw-sdk (remove copy from @shared) - match slats+flaps position dots to actual positions - remove speed tape outline right - remove spaces in FMA E2 cell (i.e. 1FD2 instead of 1 FD 2) - fix LS info box position (push a little bit upwards) - integrate PR #8235 (FMA pos. update) & #8214 (move trans alt/lvl to arinc bus) - make tens of digital altitude readout font smaller & push to right - altitude tape now listens to baro corrected altitude * revert changes to flaps/slats position * revert font for tens of altitude * activate GearIndicator, use LGCIU input for now * PFD linting * QNH, RA and altitude readout position update

BravoMike99 and others added 4 commits September 28, 2023 22:01

fix(fma): add smaller font size & center CLB

873e21b

fix(fma): AB font size, CLB pos

4578574

fix(fma): revert font back to medium

73f8bc0

Reverts fma font back to medium taking into account close up PFD pictures. Armed font should be the same size as AP/ATHR/FD status font.

fix(fma): CLB alingment and armed font size

e6329b0

Changes CLB alignment and font size according to closeup PFD refs.

BravoMike99 changed the title ~~fix: FMA CLB armed position~~ fix(fma): armed font size and positions Oct 4, 2023

BravoMike99 and others added 17 commits October 4, 2023 23:27

fix(fma): flex text box and alignments

b437a64

Merge branch 'flybywiresim:master' into fix-fma-clb-armed

7eb8526

fix(fma): MAN pos in non flex fma

8b78463

fix(fma): mode change box size of A1 cell

c1f08bd

slightly reduce armed fma font size

7f08b1a

fix armed mode y pos & A3 cell

591e297

fix(fma): Y & X pos of vertical armed modes

433e943

revert ATHR & AB message Y pos

f668f68

Fixing only the AB/ATHR messages clashes with flex/toga/mct box.

fix vertical armed mode X & mode change size

c3cc0bf

hide + sign if V/S or FPA is 0

1b71819

change lateral & vertical mode change

ebb8d89

adjust V/S & FPA for new mode change

c7c4207

Adds subject to dynamically change the font size of V/S and FPA as they are smaller IRL. This way, they fit into the box. Also adds empty space when FPA is 0

Merge branch 'flybywiresim:master' into fix-fma-clb-armed

25ca54a

improve vertical mode armed pos

a381c28

reduce font size on THR idle

9678beb

fix typo in G/S* and FINAL pos

c61360a

update changelog

b9c2873

BravoMike99 changed the title ~~fix(fma): armed font size and positions~~ fix(pfd): Improve FMA font size, mode change box & positions Oct 15, 2023

BravoMike99 marked this pull request as ready for review October 15, 2023 17:04

remove leftover comment

3cfef09

tracernz added this to the v0.12.0 milestone Oct 24, 2023

beheh approved these changes Nov 13, 2023

View reviewed changes

github-actions bot added the QA Passed label Nov 18, 2023

lukecologne reviewed Nov 23, 2023

View reviewed changes

fbw-a32nx/src/systems/instruments/src/PFD/FMA.tsx Outdated Show resolved Hide resolved

lukecologne and others added 3 commits November 23, 2023 14:38

Merge branch 'master' into fix-fma-clb-armed

82edff9

use whitespaces for CLB armed pos

e2b4aad

Merge branch 'master' into fix-fma-clb-armed

4d24b8a

fix: fix TCAS armed position after font size change

8767b17

fix(fma): center TCAS armed position

e4d8a3c

Merge branch 'master' into fix-fma-clb-armed

9ffaa95

beheh enabled auto-merge (squash) December 1, 2023 10:00

beheh merged commit df02257 into flybywiresim:master Dec 1, 2023
6 checks passed

BravoMike99 mentioned this pull request Dec 1, 2023

fix(fma): lateral mode change box start position #8320

Merged

flogross89 mentioned this pull request Feb 3, 2024

fix(a380x/pfd): visuals update & baro alt fix #8463

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(pfd): Improve FMA font size, mode change box & positions #8235

fix(pfd): Improve FMA font size, mode change box & positions #8235

BravoMike99 commented Sep 28, 2023 •

edited

Loading

beheh commented Oct 18, 2023 •

edited

Loading

lukecologne commented Oct 18, 2023 •

edited

Loading

BravoMike99 commented Oct 18, 2023

beheh commented Oct 25, 2023 •

edited

Loading

BravoMike99 commented Oct 27, 2023

beheh commented Nov 13, 2023

alepouna commented Nov 18, 2023

lukecologne commented Nov 24, 2023 •

edited

Loading

lukecologne commented Nov 24, 2023

lukecologne commented Nov 24, 2023

BravoMike99 commented Nov 25, 2023

lukecologne commented Nov 25, 2023 •

edited

Loading

lukecologne commented Nov 25, 2023 •

edited

Loading

beheh commented Nov 25, 2023 •

edited

Loading

BravoMike99 commented Nov 25, 2023

fix(pfd): Improve FMA font size, mode change box & positions #8235

fix(pfd): Improve FMA font size, mode change box & positions #8235

Conversation

BravoMike99 commented Sep 28, 2023 • edited Loading

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

beheh commented Oct 18, 2023 • edited Loading

lukecologne commented Oct 18, 2023 • edited Loading

BravoMike99 commented Oct 18, 2023

beheh commented Oct 25, 2023 • edited Loading

BravoMike99 commented Oct 27, 2023

beheh commented Nov 13, 2023

alepouna commented Nov 18, 2023

lukecologne commented Nov 24, 2023 • edited Loading

lukecologne commented Nov 24, 2023

lukecologne commented Nov 24, 2023

BravoMike99 commented Nov 25, 2023

lukecologne commented Nov 25, 2023 • edited Loading

lukecologne commented Nov 25, 2023 • edited Loading

beheh commented Nov 25, 2023 • edited Loading

BravoMike99 commented Nov 25, 2023

BravoMike99 commented Sep 28, 2023 •

edited

Loading

beheh commented Oct 18, 2023 •

edited

Loading

lukecologne commented Oct 18, 2023 •

edited

Loading

beheh commented Oct 25, 2023 •

edited

Loading

lukecologne commented Nov 24, 2023 •

edited

Loading

lukecologne commented Nov 25, 2023 •

edited

Loading

lukecologne commented Nov 25, 2023 •

edited

Loading

beheh commented Nov 25, 2023 •

edited

Loading