-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/mfd): PERF APPR minimums input logic #9666
base: master
Are you sure you want to change the base?
fix(a380x/mfd): PERF APPR minimums input logic #9666
Conversation
…imums-input-logic merge upstream/master
fbw-a380x/src/systems/instruments/src/MFD/pages/common/DataEntryFormats.tsx
Show resolved
Hide resolved
fbw-a380x/src/systems/instruments/src/MFD/pages/common/DataEntryFormats.tsx
Outdated
Show resolved
Hide resolved
return null; | ||
} | ||
if (input === 'NONE' || input === 'NO' || input === 'NO DH' || input === 'NODH') { | ||
return input; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird to not normalise them in the parser. Why not do that and avoid any other code having to deal with multiple different values that have the same meaning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was gonna comment the same but assumed it needed to keep displaying the same text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wanted to do that and return null, but when I did so, I came across a problem - when entering a value into the RADIO field, going to any other MFD page and then back to PERF APPR, the value go deleted, both from the field and the actual minimum variable. That's because InputField.ts sets the actual text value of the field from the specified variable of the component. The value of those strings in minimums altitude is basically null
, so when rendering the page again, it would fall to the if which populates placeholders in the field, because the variable would be null. That's why it's done like this, to keep even the string value in the input field. If there's a better way to do this, I'm of course open to suggestions, it's just that I didn't figure out a better way to work with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird to not normalise them in the parser. Why not do that and avoid any other code having to deal with multiple different values that have the same meaning?
So what's the verdict on this one ?
…imums-input-logic
…imums-input-logic
@tracernz So is there anything I should change here ? |
Fixes #9114
Summary of Changes
NO
,NONE
,NODH
,NO DH
Screenshots (if necessary)
References
Issue linked
Additional context
Discord username (if different from GitHub): Pruznak
Testing instructions
NONE
,NO
,NODH
,NO DH
) into the RADIO field and make sure they are accepted as a valid input.FORMAT ERROR
is displayed in the "scratchpad"ENTRY OUT OF RANGE
is displayed in the "scratchpad"----- FT
upon pressing enter. Delete the value in the filled in field and try to fill in the other one with a valid input - should go through normally.How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.