feat: takeoff performance documentation #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valastiri
added
the
waiting on a32nx PR
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
donstim
requested changes
Jun 28, 2024
Meqolo
reviewed
Jun 28, 2024
alepouna
reviewed
Jun 29, 2024
There was a problem hiding this comment.
Leaving some comments. For the 10-9A remarks on the performance.md I feel like after one mention its enough, but perhaps alternatively we could add some 'on hover' mention of the 10-9A (or just reference it once as is), this is up to you - please note to not ignore the mention in takeoff-perf-calc.md regardless of previous choice
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
alepouna review Co-authored-by: alepouna <98479040+alepouna@users.noreply.github.com>
Sleinmaster
reviewed
Jun 29, 2024
Sleinmaster
reviewed
Jun 29, 2024
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
Sleinmaster
reviewed
Jun 29, 2024
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
Sleinmaster
reviewed
Jun 29, 2024
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
donstim
removed
the
waiting on a32nx PR
|
Should remove the waiting on a32nx pr label |
donstim
requested changes
Jun 29, 2024
|
|
||
| **Runway Bearing** | ||
|
|
||
| - This is the magnetic direction of the runway. It will be entered automatically after entering the runway number. |
There was a problem hiding this comment.
Suggested change: Replace "This is the magnetic direction of the runway" with "This is the direction of the runway with respect to magnetic North" (or "referenced to magnetic North") or similar.
There was a problem hiding this comment.
modified Slein's suggest to accommodate the 2nd option here.
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
docs/pilots-corner/advanced-guides/flight-planning/takeoff-perf-calc.md
Outdated
Show resolved
Hide resolved
Sleinmaster
requested changes
Jun 29, 2024
|
Strict Build Failed! ❌ - Please checkout this PR locally to fix the issue before merging or see checks. |
github-actions
bot
merged commit 27c6437
into
flybywiresim:primary
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In support of A32NX PR
Utilizes doc from @donstim with populated data.
Beginner Guide - Preparing MCDU has been altered to accommodate loss of auto LSK for vspeeds due to upcoming PR + Perf Calc
New Inclusions
docs.flybywiresim.com/flypad-performance/Notes
I have split the pages into the general flypadOS 3 performance page AND a new advanced guide detailing how to use the calculator appropriately.
The EFB performance page has what the calculator is capable of and details on what each field is used for.
I'm not sure if we should include the entire example provided by Don on the EFB performance page or not. I have a use case to add this as an admonition with the entirety of the content and remove the advanced guides page.
TODO
Location
Discord username (if different from GitHub): valastiri