limit portrait by height #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always sizing the image to the maximum width gives an option for limiting by height to prevent portrait beeing renderd to huge. Implementation is based on @pjan fork. Solves @rmeissn issue flyfloor#5 prop limitHeight: 0 - for not limiting by height - default value value - max height
|
@jerryshew Do you plan to merge this feature in the future? It would be very handy for my project. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always sizing the image to the maximum width gives an option for limiting by height to prevent portrait beeing renderd to huge. Implementation is based on @pjan fork.
Solves @rmeissn issue #5
prop limitHeight:
0 - for not limiting by height - default value
value - max height
Example
default
limitHeight={800}