crop max size #25
Open
crop max size #25
+33
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until version 1.0.5 you ware able to define the max crop size. This was a good feature we miss in our Project. With crop(maxWidth, maxHeight) you can define the max crop size. I just used the same idea as the old implementation.
|
@jerryshew Do you plan to merge this feature in the future? It would be very handy for my project. |
Owner
|
@jerryshew Thanks for responding to this PR! We forked the library and included the requested changes into this fork, that is still on version 1.1.2 (as our project still uses React v0.15, that is not compatible with your version 1.2.0). See https://github.com/slidewiki/react-image-cropper |
|
I think this is a required PR we need some way to restrict the max height and max width of the cropper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until version 1.0.5 you ware able to define the max crop size. This was
a good feature we miss in our Project.
With crop(maxWidth, maxHeight) you can define the max crop size. I just
used the same idea from the old implementation.
Signed-off-by: Tinsaye Abye abye@studserv.uni-leipzig.de