Replace telnet shell with http api #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhnasa
force-pushed
the
replace-telnet-with-http
branch
from
078b276 to
18b75f1
Compare
dhnasa
force-pushed
the
replace-telnet-with-http
branch
from
18b75f1 to
82627b4
Compare
Collaborator
Author
|
Daemon no longer logs sla violations on its own. Is this a problem? |
dhnasa
force-pushed
the
replace-telnet-with-http
branch
from
82627b4 to
ad008c0
Compare
dhnasa
force-pushed
the
replace-telnet-with-http
branch
4 times, most recently
from
0d24394 to
f0fdbe5
Compare
dhnasa
force-pushed
the
replace-telnet-with-http
branch
2 times, most recently
from
b5489aa to
f621f48
Compare
dhnasa
force-pushed
the
replace-telnet-with-http
branch
3 times, most recently
from
8fdbbc0 to
3d6501f
Compare
dhnasa
force-pushed
the
replace-telnet-with-http
branch
from
3d6501f to
ef8c45b
Compare
ctheune
requested changes
Oct 18, 2023
Member
ctheune
left a comment
ctheune
left a comment
There was a problem hiding this comment.
This looks great. There's a few minor changes I'd like to see and the test coverage for the token authentication should be extended.
dhnasa
force-pushed
the
replace-telnet-with-http
branch
from
ef8c45b to
0e25387
Compare
Member
|
Getting there ... :) |
dhnasa
force-pushed
the
replace-telnet-with-http
branch
from
0e25387 to
cfda182
Compare
ctheune
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in preparation for #37
Replace prettytable with rich
Replace telnet shell with HTTP API
Migrate
backy checktobacky client checkand use the new HTTP API (breaking)Security implications