V1.5 patch 1 (#3668)

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
flyteorg · May 11, 2023 · cd3f29d · cd3f29d
1 parent bc521da
commit cd3f29d
Show file tree

Hide file tree

Showing 24 changed files with 110 additions and 91 deletions.
diff --git a/CHANGELOG/CHANGELOG-v1.5.1.md b/CHANGELOG/CHANGELOG-v1.5.1.md
@@ -0,0 +1,13 @@
+# Flyte 1.5.1 Patch Release
+
+This is a patch release that only contains one change - https://github.com/flyteorg/flyteadmin/pull/560
+which cherry-picks https://github.com/flyteorg/flyteadmin/pull/554.
+
+PR #554 adds a migration that remediates an issue that we discovered with very old installations of Flyte. Basically one of the tables `node_executions` has a self-referencing foreign key. The main `id` column of the table is a `bigint` whereas the self-foreign-key `parent_id` was an `int`. This was a rooted in an early version of gorm and should not affect most users. Out of an abundance of caution however, we are adding a migration to patch this issue in a manner that minimizes any locking.
+
+## To Deploy
+When you deploy this release of Flyte, you should make sure that you have more than one pod for Admin running. (If you are running the flyte-binary helm chart, this patch release does not apply to you at all. All those deployments should already have the correct column type.) When the two new migrations that #554 added runs, the first one may take an extended period of time (hours). However, this is entirely non-blocking as long as there is another Admin instance available to serve traffic.
+
+The second migration is locking, but even on very large tables, this migration was over in ~5 seconds, so you should not see any noticeable downtime whatsoever.
+
+The migration will also check to see that your database falls into this category before running (ie, the `parent_id` and the `id` columns in `node_executions` are mismatched). You can also do check this yourself using psql. If this migration is not needed, the migration will simply mark itself as complete and be a no-op otherwise.
diff --git a/charts/flyte-core/README.md b/charts/flyte-core/README.md
@@ -151,7 +151,7 @@ helm install gateway bitnami/contour -n flyte
 | flyteadmin.extraArgs | object | `{}` | Appends extra command line arguments to the serve command |
 | flyteadmin.image.pullPolicy | string | `"IfNotPresent"` |  |
 | flyteadmin.image.repository | string | `"cr.flyte.org/flyteorg/flyteadmin"` | Docker image for Flyteadmin deployment |
-| flyteadmin.image.tag | string | `"v1.1.88"` |  |
+| flyteadmin.image.tag | string | `"v1.1.88.1"` |  |
 | flyteadmin.initialProjects | list | `["flytesnacks","flytetester","flyteexamples"]` | Initial projects to create |
 | flyteadmin.nodeSelector | object | `{}` | nodeSelector for Flyteadmin deployment |
 | flyteadmin.podAnnotations | object | `{}` | Annotations for Flyteadmin pods |
@@ -213,7 +213,7 @@ helm install gateway bitnami/contour -n flyte
 | flytescheduler.configPath | string | `"/etc/flyte/config/*.yaml"` | Default regex string for searching configuration files |
 | flytescheduler.image.pullPolicy | string | `"IfNotPresent"` | Docker image pull policy |
 | flytescheduler.image.repository | string | `"cr.flyte.org/flyteorg/flytescheduler"` | Docker image for Flytescheduler deployment |
-| flytescheduler.image.tag | string | `"v1.1.88"` | Docker image tag |
+| flytescheduler.image.tag | string | `"v1.1.88.1"` | Docker image tag |
 | flytescheduler.nodeSelector | object | `{}` | nodeSelector for Flytescheduler deployment |
 | flytescheduler.podAnnotations | object | `{}` | Annotations for Flytescheduler pods |
 | flytescheduler.priorityClassName | string | `""` | Sets priorityClassName for flyte scheduler pod(s). |

diff --git a/charts/flyte-core/values.yaml b/charts/flyte-core/values.yaml
@@ -16,7 +16,7 @@ flyteadmin:
   image:
     # -- Docker image for Flyteadmin deployment
     repository: cr.flyte.org/flyteorg/flyteadmin # FLYTEADMIN_IMAGE
-    tag: v1.1.88 # FLYTEADMIN_TAG
+    tag: v1.1.88.1 # FLYTEADMIN_TAG
     pullPolicy: IfNotPresent
   # -- Additional flyteadmin container environment variables
   #
@@ -97,7 +97,7 @@ flytescheduler:
     # -- Docker image for Flytescheduler deployment
     repository: cr.flyte.org/flyteorg/flytescheduler # FLYTESCHEDULER_IMAGE
     # -- Docker image tag
-    tag: v1.1.88 # FLYTESCHEDULER_TAG
+    tag: v1.1.88.1 # FLYTESCHEDULER_TAG
     # -- Docker image pull policy
     pullPolicy: IfNotPresent
   # -- Default resources requests and limits for Flytescheduler deployment

diff --git a/charts/flyte/README.md b/charts/flyte/README.md
diff --git a/charts/flyte/values.yaml b/charts/flyte/values.yaml
@@ -16,7 +16,7 @@ flyte:
       # -- Docker image for Flyteadmin deployment
       repository: cr.flyte.org/flyteorg/flyteadmin # FLYTEADMIN_IMAGE
       # -- Docker image tag
-      tag: v1.1.88 # FLYTEADMIN_TAG
+      tag: v1.1.88.1 # FLYTEADMIN_TAG
       # -- Docker image pull policy
       pullPolicy: IfNotPresent
     # -- Additional flyteadmin container environment variables
@@ -84,7 +84,7 @@ flyte:
       # -- Docker image for Flytescheduler deployment
       repository: cr.flyte.org/flyteorg/flytescheduler # FLYTESCHEDULER_IMAGE
       # -- Docker image tag
-      tag: v1.1.88 # FLYTESCHEDULER_TAG
+      tag: v1.1.88.1 # FLYTESCHEDULER_TAG
       # -- Docker image pull policy
       pullPolicy: IfNotPresent
     # -- Default resources requests and limits for Flytescheduler deployment

diff --git a/deployment/eks/flyte_aws_scheduler_helm_generated.yaml b/deployment/eks/flyte_aws_scheduler_helm_generated.yaml
@@ -868,7 +868,7 @@ spec:
           - /etc/flyte/config/*.yaml
           - migrate
           - run
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: run-migrations
           volumeMounts:
@@ -885,7 +885,7 @@ spec:
           - flytesnacks
           - flytetester
           - flyteexamples
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: seed-projects
           volumeMounts:
@@ -899,7 +899,7 @@ spec:
           - /etc/flyte/config/*.yaml
           - clusterresource
           - sync
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: sync-cluster-resources
           volumeMounts:
@@ -912,7 +912,7 @@ spec:
           - mountPath: /etc/secrets/
             name: admin-secrets
         - name: generate-secrets
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           command: ["/bin/sh", "-c"]
           args:
@@ -935,7 +935,7 @@ spec:
         - --config
         - /etc/flyte/config/*.yaml
         - serve
-        image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+        image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
         imagePullPolicy: "IfNotPresent"
         name: flyteadmin
         ports:
@@ -1036,7 +1036,7 @@ spec:
             - /etc/flyte/config/*.yaml
             - clusterresource
             - run
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: sync-cluster-resources
           volumeMounts:

diff --git a/deployment/eks/flyte_generated.yaml b/deployment/eks/flyte_generated.yaml
@@ -8799,7 +8799,7 @@ spec:
         - --config
         - /etc/flyte/config/*.yaml
         - serve
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: flyteadmin
         ports:
@@ -8846,7 +8846,7 @@ spec:
         - /etc/flyte/config/*.yaml
         - migrate
         - run
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: run-migrations
         volumeMounts:
@@ -8863,7 +8863,7 @@ spec:
         - flytesnacks
         - flytetester
         - flyteexamples
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: seed-projects
         volumeMounts:
@@ -8877,7 +8877,7 @@ spec:
         - /etc/flyte/config/*.yaml
         - clusterresource
         - sync
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: sync-cluster-resources
         volumeMounts:
@@ -8897,7 +8897,7 @@ spec:
           valueFrom:
             fieldRef:
               fieldPath: metadata.namespace
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: generate-secrets
         volumeMounts:
@@ -9270,7 +9270,7 @@ spec:
             - /etc/flyte/config/*.yaml
             - clusterresource
             - sync
-            image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+            image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
             imagePullPolicy: IfNotPresent
             name: sync-cluster-resources
             volumeMounts:

diff --git a/deployment/eks/flyte_helm_controlplane_generated.yaml b/deployment/eks/flyte_helm_controlplane_generated.yaml
@@ -574,7 +574,7 @@ spec:
           - /etc/flyte/config/*.yaml
           - migrate
           - run
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: run-migrations
           volumeMounts:
@@ -591,7 +591,7 @@ spec:
           - flytesnacks
           - flytetester
           - flyteexamples
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: seed-projects
           volumeMounts:
@@ -605,7 +605,7 @@ spec:
           - /etc/flyte/config/*.yaml
           - clusterresource
           - sync
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: sync-cluster-resources
           volumeMounts:
@@ -618,7 +618,7 @@ spec:
           - mountPath: /etc/secrets/
             name: admin-secrets
         - name: generate-secrets
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           command: ["/bin/sh", "-c"]
           args:
@@ -641,7 +641,7 @@ spec:
         - --config
         - /etc/flyte/config/*.yaml
         - serve
-        image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+        image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
         imagePullPolicy: "IfNotPresent"
         name: flyteadmin
         ports:
@@ -742,7 +742,7 @@ spec:
             - /etc/flyte/config/*.yaml
             - clusterresource
             - run
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: sync-cluster-resources
           volumeMounts:
@@ -952,7 +952,7 @@ spec:
         - precheck
         - --config
         - /etc/flyte/config/*.yaml
-        image: "cr.flyte.org/flyteorg/flytescheduler:v1.1.88"
+        image: "cr.flyte.org/flyteorg/flytescheduler:v1.1.88.1"
         imagePullPolicy: "IfNotPresent"
         name: flytescheduler-check
         volumeMounts:
@@ -968,7 +968,7 @@ spec:
         - run
         - --config
         - /etc/flyte/config/*.yaml
-        image: "cr.flyte.org/flyteorg/flytescheduler:v1.1.88"
+        image: "cr.flyte.org/flyteorg/flytescheduler:v1.1.88.1"
         imagePullPolicy: "IfNotPresent"
         name: flytescheduler
         ports:

diff --git a/deployment/eks/flyte_helm_generated.yaml b/deployment/eks/flyte_helm_generated.yaml
@@ -899,7 +899,7 @@ spec:
           - /etc/flyte/config/*.yaml
           - migrate
           - run
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: run-migrations
           volumeMounts:
@@ -916,7 +916,7 @@ spec:
           - flytesnacks
           - flytetester
           - flyteexamples
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: seed-projects
           volumeMounts:
@@ -930,7 +930,7 @@ spec:
           - /etc/flyte/config/*.yaml
           - clusterresource
           - sync
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: sync-cluster-resources
           volumeMounts:
@@ -943,7 +943,7 @@ spec:
           - mountPath: /etc/secrets/
             name: admin-secrets
         - name: generate-secrets
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           command: ["/bin/sh", "-c"]
           args:
@@ -966,7 +966,7 @@ spec:
         - --config
         - /etc/flyte/config/*.yaml
         - serve
-        image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+        image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
         imagePullPolicy: "IfNotPresent"
         name: flyteadmin
         ports:
@@ -1067,7 +1067,7 @@ spec:
             - /etc/flyte/config/*.yaml
             - clusterresource
             - run
-          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88"
+          image: "cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1"
           imagePullPolicy: "IfNotPresent"
           name: sync-cluster-resources
           volumeMounts:
@@ -1277,7 +1277,7 @@ spec:
         - precheck
         - --config
         - /etc/flyte/config/*.yaml
-        image: "cr.flyte.org/flyteorg/flytescheduler:v1.1.88"
+        image: "cr.flyte.org/flyteorg/flytescheduler:v1.1.88.1"
         imagePullPolicy: "IfNotPresent"
         name: flytescheduler-check
         volumeMounts:
@@ -1293,7 +1293,7 @@ spec:
         - run
         - --config
         - /etc/flyte/config/*.yaml
-        image: "cr.flyte.org/flyteorg/flytescheduler:v1.1.88"
+        image: "cr.flyte.org/flyteorg/flytescheduler:v1.1.88.1"
         imagePullPolicy: "IfNotPresent"
         name: flytescheduler
         ports:

diff --git a/deployment/gcp/flyte_generated.yaml b/deployment/gcp/flyte_generated.yaml
@@ -8841,7 +8841,7 @@ spec:
         - --config
         - /etc/flyte/config/*.yaml
         - serve
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: flyteadmin
         ports:
@@ -8888,7 +8888,7 @@ spec:
         - /etc/flyte/config/*.yaml
         - migrate
         - run
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: run-migrations
         volumeMounts:
@@ -8905,7 +8905,7 @@ spec:
         - flytesnacks
         - flytetester
         - flyteexamples
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: seed-projects
         volumeMounts:
@@ -8919,7 +8919,7 @@ spec:
         - /etc/flyte/config/*.yaml
         - clusterresource
         - sync
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: sync-cluster-resources
         volumeMounts:
@@ -8939,7 +8939,7 @@ spec:
           valueFrom:
             fieldRef:
               fieldPath: metadata.namespace
-        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+        image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
         imagePullPolicy: IfNotPresent
         name: generate-secrets
         volumeMounts:
@@ -9312,7 +9312,7 @@ spec:
             - /etc/flyte/config/*.yaml
             - clusterresource
             - sync
-            image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88
+            image: cr.flyte.org/flyteorg/flyteadmin:v1.1.88.1
             imagePullPolicy: IfNotPresent
             name: sync-cluster-resources
             volumeMounts: