add sub_node_interface field to array node #6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6018 +/- ##
==========================================
- Coverage 37.04% 37.04% -0.01%
==========================================
Files 1316 1316
Lines 132262 132267 +5
==========================================
- Hits 48998 48997 -1
- Misses 79002 79008 +6
Partials 4262 4262
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
|
Can we move this out of draft mode, @pvditt ? |
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
pvditt
changed the title
|
@eapolinario yup - was waiting on some consensus on some backward compatibility concerns. |
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
|
@pvditt , can you merge master to get rid of the |
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
hamersaw
approved these changes
Nov 27, 2024
eapolinario
approved these changes
Dec 2, 2024
eapolinario
pushed a commit
that referenced
this pull request
Dec 2, 2024
* add is_original_sub_node_interface field to array node Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * update idl Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * make arraynode compilation backwards compatible Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * use boolvalue for is_original_sub_node_interface Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
eapolinario
added a commit
that referenced
this pull request
Dec 2, 2024
* add is_original_sub_node_interface field to array node * update idl * make arraynode compilation backwards compatible * use boolvalue for is_original_sub_node_interface --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> Co-authored-by: Paul Dittamo <37558497+pvditt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link