-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flytepropeller][flyteadmin] Streaming Decks V2 #6053
Open
Future-Outlier
wants to merge
28
commits into
master
Choose a base branch
from
streaming-deck-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+144
−19
Open
Changes from 22 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
54aa165
add tests from Yi-Cheng
Future-Outlier 9ed6b6e
helped by Kevin and Yi-Cheng
Future-Outlier 4b4f6bd
lint
Future-Outlier dd774cb
nit
Future-Outlier 0bb8e91
add comments
Future-Outlier 25fea29
add comments and better solution for backward compativle
Future-Outlier 4e24e91
better comments
Future-Outlier 8d1d0e4
DeckStatus
Future-Outlier 31853bb
rename GetDeckStatus
Future-Outlier 4068043
comments
Future-Outlier 65b6efe
lint
Future-Outlier 137579f
fix
Future-Outlier 04f7fbc
Merge branch 'master' into streaming-deck-v2
Future-Outlier aa56d64
Merge branch 'master' into streaming-deck-v2
Future-Outlier a16851f
use BoolValue as IDL, suggested by Eduardo
Future-Outlier 7314455
change commennts
Future-Outlier 19498f5
update
Future-Outlier 74f595f
fix
Future-Outlier 3bd3336
fix
Future-Outlier f6d8493
Merge branch 'master' into streaming-deck-v2
Future-Outlier 4b56e52
fix
Future-Outlier db4b19e
remove unused ogic
Future-Outlier 2737251
Update flyteidl/protos/flyteidl/core/tasks.proto
Future-Outlier 564dc5f
Update flyteidl/protos/flyteidl/core/tasks.proto
Future-Outlier 69ba94e
Merge remote-tracking branch 'origin' into streaming-deck-v2
eapolinario c992eae
Merge branch 'master' into streaming-deck-v2
Future-Outlier 0b91b5c
Update by Kevin's advice
Future-Outlier 1d18265
update
Future-Outlier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test here showing that the deck uri also shows up in the case of failed executions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/flyteorg/flyte/pull/6053/files#diff-a54d30dd5d924cda2f14ca936e4173fc9a263079552e66c2c1c196001631ae96R201-R231