Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guides #6150

Merged

Conversation

davidmirror-ops
Copy link
Contributor

@davidmirror-ops davidmirror-ops commented Jan 8, 2025

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

This PR adds missing links, reorganizes some instructions and introduces the recommendation to use PR labels to build better release notes.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • [] All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

Documentation enhancement PR that reorganizes contribution guidelines, fixes typo in PR label recommendations, and updates community meeting schedules. Improves development setup instructions and code formatting guidelines for Go and Python. Clarifies project's monorepo structure for better developer understanding. Security configurations updated across manifest files with new haSharedSecret values and checksum updates in sandbox-bundled manifests.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 2

Signed-off-by: davidmirror-ops <david.espejo@union.ai>
Signed-off-by: davidmirror-ops <david.espejo@union.ai>
Signed-off-by: davidmirror-ops <david.espejo@union.ai>
Signed-off-by: davidmirror-ops <david.espejo@union.ai>
Signed-off-by: davidmirror-ops <david.espejo@union.ai>
Signed-off-by: davidmirror-ops <david.espejo@union.ai>
@flyte-bot
Copy link
Collaborator

flyte-bot commented Jan 8, 2025

Code Review Agent Run #90de40

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: b97c103..5d52ee2
    • docs/community/contribute/contribute_code.rst
    • docs/community/contribute/index.rst
    • docs/community/index.rst
  • Files skipped - 2
    • .github/PULL_REQUEST_TEMPLATE.md - Reason: Filter setting
    • docs/community/contribute/contribute_docs.md - Reason: Filter setting
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

@flyte-bot
Copy link
Collaborator

flyte-bot commented Jan 8, 2025

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Documentation - Documentation Updates and Contribution Guidelines

contribute_code.rst - Added monorepo clarification and removed outdated documentation setup instructions

index.rst - Updated contribution guidelines with PR labeling and code formatting standards

index.rst - Updated community meeting schedules and added new contributor sync information

Other Improvements - Security Configuration Updates

complete-agent.yaml - Updated HA shared secret and checksum values

complete.yaml - Updated HA shared secret and checksum values

dev.yaml - Updated HA shared secret and checksum values

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.01%. Comparing base (27c9edd) to head (405dfbf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6150      +/-   ##
==========================================
- Coverage   37.01%   37.01%   -0.01%     
==========================================
  Files        1317     1317              
  Lines      132523   132523              
==========================================
- Hits        49060    49059       -1     
- Misses      79217    79218       +1     
  Partials     4246     4246              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.23% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.85% <ø> (ø)
unittests-flytepropeller 42.64% <ø> (ø)
unittests-flytestdlib 55.17% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: davidmirror-ops <david.espejo@union.ai>
@flyte-bot
Copy link
Collaborator

flyte-bot commented Jan 8, 2025

Code Review Agent Run #90ea89

Actionable Suggestions - 0
Review Details
  • Files reviewed - 4 · Commit Range: 5d52ee2..405dfbf
    • docker/sandbox-bundled/manifests/complete-agent.yaml
    • docker/sandbox-bundled/manifests/complete.yaml
    • docker/sandbox-bundled/manifests/dev.yaml
    • docs/community/contribute/index.rst
  • Files skipped - 0
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

@davidmirror-ops davidmirror-ops merged commit 9193dd6 into flyteorg:master Jan 9, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants